New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed broken template engine unit tests #247

Merged
merged 1 commit into from Jul 1, 2016

Conversation

Projects
None yet
2 participants
@ancho
Member

ancho commented Nov 20, 2015

The FreemarkerTemplateEngineRenderingTest failed. Fixed template files and refactored the AbstractTemplateEngineRenderingTest a bit.

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock
Member

jonbullock commented Jan 14, 2016

Thanks @ancho

@jonbullock jonbullock added this to the v2.5.0 milestone Jan 14, 2016

@jonbullock jonbullock self-assigned this Jan 14, 2016

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Jan 14, 2016

Member

Long shot I know, but I don't suppose you remember what the test failed on do you?

Member

jonbullock commented Jan 14, 2016

Long shot I know, but I don't suppose you remember what the test failed on do you?

@ancho

This comment has been minimized.

Show comment
Hide comment
@ancho

ancho Jan 15, 2016

Member

We had common (duplicated) expectations on the rendered output for all template engines. I moved them to the AbstractTemplateEngineRenderingTest.

The Freemarker templates used different html elements which caused the FreemarkerTemplateEngineRenderingTest to fail.

But thinking it through it is maybe not the best idea to define a common set of expectations on the rendering output as it dictates the structure of all templates.

It's maybe better to change the expectations of the concrete Test.

Member

ancho commented Jan 15, 2016

We had common (duplicated) expectations on the rendered output for all template engines. I moved them to the AbstractTemplateEngineRenderingTest.

The Freemarker templates used different html elements which caused the FreemarkerTemplateEngineRenderingTest to fail.

But thinking it through it is maybe not the best idea to define a common set of expectations on the rendering output as it dictates the structure of all templates.

It's maybe better to change the expectations of the concrete Test.

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Jan 15, 2016

Member

The tests are dependant on the templates in the src/test/resources regardless and at the moment these tests are more integration tests to ensure the template engine code is working as expected. I'm happy to alter the structure when there is a need to test a different expectation of one of the template engines.

Member

jonbullock commented Jan 15, 2016

The tests are dependant on the templates in the src/test/resources regardless and at the moment these tests are more integration tests to ensure the template engine code is working as expected. I'm happy to alter the structure when there is a need to test a different expectation of one of the template engines.

@jonbullock jonbullock merged commit 8c2c58e into jbake-org:master Jul 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonbullock added a commit that referenced this pull request Jul 1, 2016

@ancho ancho deleted the ancho:feature/fix-broken-tests branch Oct 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment