Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fixed broken template engine unit tests #247
We had common (duplicated) expectations on the rendered output for all template engines. I moved them to the AbstractTemplateEngineRenderingTest.
The Freemarker templates used different html elements which caused the FreemarkerTemplateEngineRenderingTest to fail.
But thinking it through it is maybe not the best idea to define a common set of expectations on the rendering output as it dictates the structure of all templates.
It's maybe better to change the expectations of the concrete Test.
The tests are dependant on the templates in the src/test/resources regardless and at the moment these tests are more integration tests to ensure the template engine code is working as expected. I'm happy to alter the structure when there is a need to test a different expectation of one of the template engines.