New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed loading of RenderingTool Providers #248

Merged
merged 1 commit into from Jul 2, 2016

Conversation

Projects
None yet
2 participants
@ancho
Member

ancho commented Nov 20, 2015

Renamed provider-configuration file according to https://docs.oracle.com/javase/7/docs/api/java/util/ServiceLoader.html and wrote a little test.

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Jan 14, 2016

Member

Thanks @ancho hadn't noticed this when I raised and fixed #254, but the test class is very useful!

Member

jonbullock commented Jan 14, 2016

Thanks @ancho hadn't noticed this when I raised and fixed #254, but the test class is very useful!

@jonbullock jonbullock added the bug label Jan 14, 2016

@jonbullock jonbullock added this to the v2.5.0 milestone Jan 14, 2016

@jonbullock jonbullock self-assigned this Jan 14, 2016

@jonbullock jonbullock merged commit a973d3c into jbake-org:master Jul 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonbullock added a commit that referenced this pull request Jul 2, 2016

@ancho ancho deleted the ancho:feature/fix-serviceloader branch Oct 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment