New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring #249

Merged
merged 5 commits into from Jul 2, 2016

Conversation

Projects
None yet
2 participants
@thehereward
Contributor

thehereward commented Dec 5, 2015

A small amount of refactoring:

  • corrected a spelling
  • introduced a constant to replace a magic string
  • simplified some boolean logic
  • moved some functionality into small methods.

This reveals a couple of small issues which I may get time to address in other pull requests:

  • The 'isJson' method should probably be changed to be a little more robust in checking whether the contents is json
  • The header processing logic looks like it could be moved into a class of its own
@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Jan 14, 2016

Member

Thanks @thehereward - linking this with #231

Member

jonbullock commented Jan 14, 2016

Thanks @thehereward - linking this with #231

@jonbullock jonbullock added this to the v2.5.0 milestone Jan 14, 2016

@jonbullock jonbullock self-assigned this Jan 14, 2016

@jonbullock jonbullock merged commit 316b4cd into jbake-org:master Jul 2, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

jonbullock added a commit that referenced this pull request Jul 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment