New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore javadoc error on package #309

Merged
merged 1 commit into from Nov 16, 2016

Conversation

Projects
None yet
3 participants
@lamvak
Contributor

lamvak commented Oct 18, 2016

Running
mvn clean package
Log from master build
Log from ignore_javadoc branch build

Of course, since javadoc is used for documentation, it would be better to just fix the issues. However this allows to build the package with current shape.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 18, 2016

Coverage Status

Coverage remained the same at 70.403% when pulling 455dbf9 on lamvak:ignore_javadoc into 6dcd780 on jbake-org:master.

coveralls commented Oct 18, 2016

Coverage Status

Coverage remained the same at 70.403% when pulling 455dbf9 on lamvak:ignore_javadoc into 6dcd780 on jbake-org:master.

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Nov 12, 2016

Member

I suspect this is down to JDK8 and it's doclint, could you try the fix suggested in this blog - disabling it on the plugin section of the POM: http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html

If it works for you could you update your PR with this change to replace the "failOnError" - thanks.

Member

jonbullock commented Nov 12, 2016

I suspect this is down to JDK8 and it's doclint, could you try the fix suggested in this blog - disabling it on the plugin section of the POM: http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html

If it works for you could you update your PR with this change to replace the "failOnError" - thanks.

@jonbullock jonbullock added the change label Nov 12, 2016

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 14, 2016

Coverage Status

Coverage remained the same at 70.403% when pulling 0e2b631 on lamvak:ignore_javadoc into 086dd2a on jbake-org:master.

coveralls commented Nov 14, 2016

Coverage Status

Coverage remained the same at 70.403% when pulling 0e2b631 on lamvak:ignore_javadoc into 086dd2a on jbake-org:master.

@lamvak

This comment has been minimized.

Show comment
Hide comment
@lamvak

lamvak Nov 14, 2016

Contributor

All seem good now: see new log file
I propose to merge this as tactical fix for Java 8 compatibility and when I have a moment I can try to make the javadoc compatible with both Java 8 and 7

Contributor

lamvak commented Nov 14, 2016

All seem good now: see new log file
I propose to merge this as tactical fix for Java 8 compatibility and when I have a moment I can try to make the javadoc compatible with both Java 8 and 7

@jonbullock jonbullock added this to the v2.5.1 milestone Nov 16, 2016

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Nov 16, 2016

Member

Excellent. I'll merge this in now and be happy to accept the updated javadoc. 👍

Member

jonbullock commented Nov 16, 2016

Excellent. I'll merge this in now and be happy to accept the updated javadoc. 👍

@jonbullock jonbullock self-assigned this Nov 16, 2016

@jonbullock jonbullock merged commit 523e491 into jbake-org:master Nov 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lamvak lamvak deleted the lamvak:ignore_javadoc branch Nov 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment