New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current dir lib/* and lib/logging to classpath #564

Merged
merged 1 commit into from Nov 10, 2018

Conversation

Projects
None yet
3 participants
@maxandersen
Copy link
Contributor

maxandersen commented Nov 9, 2018

Why:

  • when running jbake on cli there is no easy way to configure logging
    nor add additional jars.

This change addreses the need by:

  • extend current searh/replace of scripts to add pwd/lib
    and lib/logging

Note: I've tested the linux sh version on OSX, don't have a way
to test Windows nor pure linux right now but I have high confidence
that it will work :)

Add current dir lib/* and lib/logging to classpath
Why:

 *  when running jbake on cli there is no easy way to configure logging
    nor add additional jars.

This change addreses the need by:

 * extend current searh/replace of scripts to add `pwd`/lib
   and lib/logging
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 9, 2018

Coverage Status

Coverage remained the same at 80.798% when pulling 810b627 on maxandersen:userlibconfig into 00ff192 on jbake-org:master.

@jonbullock jonbullock self-assigned this Nov 10, 2018

@jonbullock jonbullock added this to the v2.6.4 milestone Nov 10, 2018

@jonbullock

This comment has been minimized.

Copy link
Member

jonbullock commented Nov 10, 2018

Thanks Max 👍

@jonbullock jonbullock merged commit aebf496 into jbake-org:master Nov 10, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment