New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental asset baking while serving #583

Merged
merged 3 commits into from Jan 19, 2019

Conversation

Projects
None yet
4 participants
@jmcgarr
Copy link
Contributor

jmcgarr commented Jan 9, 2019

This is the first step to improving bake performance. The scope of this change is focused solely on copying newly changed asset files while serving content. This should work per asset file as it is changed. It should also copy asset files that exist in the content directory.

This pull request is a portion of the work contributing to #391.

Mike McGarr
Incremental asset baking while serving
This is the first step to improving bake performance. The scope of this change is focused solely on copying newly changed asset files while serving content. This should work per asset file as it is changed. It should also copy asset files that exist in the content directory.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 9, 2019

Coverage Status

Coverage decreased (-0.3%) to 80.439% when pulling 242708b on jmcgarr:incremental-asset-baking into 5261a32 on jbake-org:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 9, 2019

Coverage Status

Coverage decreased (-0.2%) to 80.548% when pulling 883e110 on jmcgarr:incremental-asset-baking into c3ca239 on jbake-org:master.

@ancho ancho self-requested a review Jan 10, 2019

@ancho

This comment has been minimized.

Copy link
Member

ancho commented Jan 10, 2019

Nice. I schedule some time for a review. Maybe end of the weekend. To much todo at present. Thank you.

@ancho
Copy link
Member

ancho left a comment

I like it. It's a first good step in the right direction. So I approve in general, but have a question about a comment in the AssetTest class.


/*
@Test
public void testAssetTargetFolder() throws Exception {

This comment has been minimized.

@ancho

ancho Jan 15, 2019

Member

Maybe remove that comment entirely. Or add an @ignore with a description why it should be ignored for now.
What do you think?

Mike McGarr and others added some commits Jan 18, 2019

Mike McGarr

@jonbullock jonbullock added this to the v2.6.4 milestone Jan 18, 2019

@ancho ancho merged commit 883e110 into jbake-org:master Jan 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jonbullock

This comment has been minimized.

Copy link
Member

jonbullock commented Jan 22, 2019

Thanks for the contribution @jmcgarr 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment