Skip to content

Chema Balsas
jbalsas

Organizations

@liferay
jbalsas commented on pull request brianchandotcom/liferay-portal#35856
@jbalsas

I sent it to myself this morning and all tests passed, so it might be a spurious error... you can check my prs to verify. Maybe retest this one? El…

jbalsas commented on issue liferay/alloy-editor#459
@jbalsas

Hey @sei-dmorda, we've answered this quite some times here and in the site, but you're 100% right that maybe it's not as clear as it should be. You…

jbalsas commented on pull request natecavanaugh/liferay-portal#3820
@jbalsas

Hey @natecavanaugh, this is still missing a big portion of the Lexicon input design like input-group-default. The markup for this, however, is not …

jbalsas commented on issue liferay/alloy-editor#459
@jbalsas

Hey @sei-dmorda, We don't currently provide this feature out of the box. It is something I've been asked before, so we might consider doing it. Th…

jbalsas commented on pull request natecavanaugh/liferay-portal#3820
@jbalsas
  • @jbalsas ff160c5
    LPS-61952 Toggle-switch help message should be wrapped and placed aft…
@jbalsas
LPS-61952 Toggle-switch help message should be wrapped and placed after the toggle
2 commits with 20 additions and 2 deletions
@jbalsas
LPS-61952 Toggle-switch label needs a wrapping span with the toggle-switch-label class
jbalsas commented on pull request natecavanaugh/liferay-portal#3819
@jbalsas

We're still missing proper markup for the help message... will resend

@jbalsas
LPS-62430 - Set default to "/message_boards/view" if nothing is passed.
2 commits with 4 additions and 5 deletions
jbalsas closed pull request jbalsas/liferay-portal#433
@jbalsas
LPS-62430 - Set default to "/message_boards/view" if nothing is passed.
jbalsas closed pull request jbalsas/liferay-portal#422
@jbalsas
LPS-62430
jbalsas opened pull request jbalsas/liferay-portal#433
@jbalsas
LPS-62430 - Set default to "/message_boards/view" if nothing is passed.
2 commits with 4 additions and 5 deletions
jbalsas commented on pull request natecavanaugh/liferay-portal#3819
@jbalsas
LPS-61952 Toggle-switch label needs a wrapping span with the toggle-switch-label class
1 commit with 8 additions and 0 deletions
jbalsas closed pull request jbalsas/liferay-portal#432
@jbalsas
LPS-62973
jbalsas commented on pull request jbalsas/liferay-portal#432
@jbalsas

Hey @mjbradford89, a couple of comments We're adding delegate listeners over and over on SPA navigation, so those listeners will get triggered mul…

jbalsas commented on pull request evannagayama/liferay-portal#508
@jbalsas

Hey guys! Thanks everyone for the quick response and the help! Should I close this one and resend after your WebDriver changes have been merged, o…

@jbalsas

Just FYI, this will only work as long as we test exclusively with english locales, but it will fail if at some point we change the user language si…

@jbalsas
jbalsas closed pull request jbalsas/liferay-portal#429
@jbalsas
LPS-62979 Prevent multiple instantiations of the same panel. Use data-toggle as toggle selector.
@jbalsas
LPS-62979 Prevent multiple instantiations of the same panel. Use data-toggle as toggle selector.
1 commit with 28 additions and 22 deletions
jbalsas closed pull request jbalsas/liferay-portal#431
@jbalsas
LPS-60244 Add lang key
jbalsas commented on pull request jbalsas/liferay-portal#431
@jbalsas

I've resent it to you here :relaxed: Thanks!

jbalsas commented on pull request jbalsas/liferay-portal#430
@jbalsas

Pull request submitted to evannagayama#508. See changes here. :octocat: Sent from GH.

@jbalsas
LPS-60244 Add lang key
4 commits with 8 additions and 0 deletions
jbalsas commented on pull request jbalsas/liferay-portal#431
@jbalsas

Hey @evannagayama, of course, it was changed to have a proper title attribute, but because of this: https://github.com/jbalsas/liferay-portal/blob/…

Something went wrong with that request. Please try again.