Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detect version from JAVA_RUNTIME_VERSION and don't use JAVA_VERS… #1632

Merged
merged 2 commits into from
Jun 8, 2023
Merged

fix: detect version from JAVA_RUNTIME_VERSION and don't use JAVA_VERS… #1632

merged 2 commits into from
Jun 8, 2023

Conversation

maxandersen
Copy link
Collaborator

fixes #1631

@quintesse
Copy link
Contributor

quintesse commented Jun 7, 2023 •
edited

So, the thinking behind this is correct... I'm just worried that there might be RELEASE files that have lines like JAVA_VERSION = XX (see spaces).

Edit: I haven't found any examples of that so far (but I also haven't found any examples where JAVA_RUNTIME_VERSION appears, so obviously there are different contents)

@maxandersen
Copy link
Collaborator Author

JAVA_RUNTIME_VERSION is part of java 21 openjdk/jdk#12813

@maxandersen maxandersen merged commit ac432ec into jbangdev:main Jun 8, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quintesse quintesse quintesse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cant use nightly build of jdk with jbang
2 participants
@maxandersen @quintesse