fix: ignore dead symbolic links and fail on explicit missing //SOURCE (#744)f #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxandersen
force-pushed
the
missingfiles
branch
from
e07c388 to
4cc9b01
Compare
//SOURCE missingfile.java will now error. //SOURCE **/*.java and it matches symoblic link which point to dead file will be ignored
maxandersen
force-pushed
the
missingfiles
branch
from
4cc9b01 to
7049af7
Compare
maxandersen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//SOURCE missingfile.java will now error.
//SOURCE **/*.java and it matches symoblic link which point to dead file will be ignored
@quintesse should we maybe ignore both cases and just print warn during --verbose ? WDYT?