Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add JReleaser configuration & templates #899

Merged
merged 7 commits into from Jul 15, 2021
Merged

chore: Add JReleaser configuration & templates #899

merged 7 commits into from Jul 15, 2021

Conversation

aalmiray
Copy link
Contributor

Initial JReleaser configuration.

@aalmiray aalmiray marked this pull request as draft May 29, 2021 10:49
@aalmiray
Copy link
Contributor Author

Don't forget to define environment variables.

JRELEASER_PROJECT_VERSION
JRELEASER_GITHUB_TOKEN

@aalmiray aalmiray changed the title chore: Add JReleaser configuraiton & templates chore: Add JReleaser configuration & templates May 29, 2021
@aalmiray
Copy link
Contributor Author

Requires jreleaser/jreleaser@bbf8076 or later as that enables:

  • copyright field on project
  • custom output directory when running on CLI
  • updates to chocolatey templates
  • dryrun = true skips validation of secrets

@maxandersen
Copy link
Collaborator

things missing so i dont have to re-remember this everytime :

  • can't seem to customize sdkman message with proper url
  • can't grok what chocolatey packager actually do; docs say need to use CI - which ci?
  • snap doesn't seem to work with build happening outside snap ci ?

@aalmiray
Copy link
Contributor Author

  • custom sdkman url: it's taken directly from the releaser's "release notes" url. Is not customizable at the moment.
  • chocolatey CI: the idea is to follow the same setup JBang has at the moment, however the JReleaser templates do not provide starting files at the moment.
  • local snap build: it used to work a couple of releases ago, perhaps I broke it.

@maxandersen maxandersen marked this pull request as ready for review July 15, 2021 20:39
@maxandersen maxandersen merged commit 546df3b into jbangdev:main Jul 15, 2021
maxandersen added a commit that referenced this pull request Jul 15, 2021
@aalmiray @maxandersen
chore: Add JReleaser configuration & templates (#899)
31b2800 
* [minor] various fixes

* chore: Add JReleaser configuraiton & templates

* chore: exclude JReleaser output from spotless checks

* chore: refine JReleaser configuration

* build: first set of removals in build/workflow for when jreleaser runs

* use right doc url

* fix: magic jreleaser fixes

Co-authored-by: Max Rydahl Andersen <manderse@redhat.com>
Co-authored-by: Max Rydahl Andersen <gitkraken@xam.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aalmiray @maxandersen