Permalink
Browse files

Added a few more FIXMEs.

  • Loading branch information...
1 parent 8ead973 commit cfcba6d13b9cf09f399c3c65832b426644a00bef @jbarnette committed Apr 20, 2008
Showing with 3 additions and 1 deletion.
  1. +3 −1 ext/spidermonkey/js_land_proxy.c
@@ -135,7 +135,6 @@ static JSBool get(JSContext* js_context, JSObject* obj, jsval id, jsval* retval)
return JS_TRUE;
}
- // Trying to call JS_GetStringBytes on a non-string causes a segfault
char* name = JS_GetStringBytes(JSVAL_TO_STRING(id));
VALUE ruby_id = rb_intern(name);
@@ -204,6 +203,9 @@ static JSBool get(JSContext* js_context, JSObject* obj, jsval id, jsval* retval)
// otherwise, it's a method being accessed as a property, which means
// we need to return a lambda
+ // FIXME: this should really wrap the Method for 'name' in a JS class
+ // rather than generating a wrapper Proc
+
else if (method_p(self, name))
{
*retval = convert_to_js(context,

0 comments on commit cfcba6d

Please sign in to comment.