Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Added some notes for the future.

  • Loading branch information...
commit d45a2d533aee5f5c4e4e3955038273ad6be79734 1 parent 4b91a3f
@jbarnette authored
Showing with 6 additions and 0 deletions.
  1. +6 −0 ext/spidermonkey/js_land_proxy.c
6 ext/spidermonkey/js_land_proxy.c
@@ -105,6 +105,12 @@ static JSBool get(JSContext* js_context, JSObject* obj, jsval id, jsval* retval)
char* name = JS_GetStringBytes(JSVAL_TO_STRING(id));
VALUE ruby_id = rb_intern(name);
+ // FIXME: this is necessarily ugly. Maybe we should write something like
+ // jsval foo = property_expression(context->js, context->global, "Johnson.Generator.create")
+ // this would make the code where we look up Johnson.Symbol cleaner too (in conversions.c)
+ // FIXME: we should probably just JS_DefineProperty this, and it shouldn't be enumerable
if(!strcasecmp("__iterator__", name)) {
jsval nsJohnson;
assert(JS_GetProperty(context->js, context->global, "Johnson", &nsJohnson) || JSVAL_VOID == nsJohnson);
Please sign in to comment.
Something went wrong with that request. Please try again.