Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Large arithmetic expressions overflow #11

Closed
tarcieri opened this Issue · 4 comments

2 participants

@tarcieri
>> Johnson::Parser.parse "1000 * 60 * 60 * 24 * 30"
=> [[:lit, -2147483648]]
@jbarnette
Owner

Argh, good catch. This constant folding may be happening in SpiderMonkey's parser. If it's in the translation bits on our side, what do you think would be the least surprising behavior? Bignum?

@tarcieri

Yes, Bignum would be fine. We're just round-tripping everything while doing some AST munging, so as long as what goes in comes out I don't really care what the intermediate representation is.

@jbarnette
Owner

Okay, Aaron and I are doing a quick round of blameshifting, and then we'll see what we can do about this. In the meantime, a patch (even if it's just a failing testcase) is most welcome. :)

@jbarnette jbarnette was assigned
@jbarnette
Owner

I, uh, think I'll close this. :heart:

@jbarnette jbarnette closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.