Large arithmetic expressions overflow #11

Closed
tarcieri opened this Issue Aug 17, 2009 · 4 comments

Comments

Projects
None yet
2 participants
@tarcieri
>> Johnson::Parser.parse "1000 * 60 * 60 * 24 * 30"
=> [[:lit, -2147483648]]
@jbarnette

This comment has been minimized.

Show comment
Hide comment
@jbarnette

jbarnette Aug 17, 2009

Owner

Argh, good catch. This constant folding may be happening in SpiderMonkey's parser. If it's in the translation bits on our side, what do you think would be the least surprising behavior? Bignum?

Owner

jbarnette commented Aug 17, 2009

Argh, good catch. This constant folding may be happening in SpiderMonkey's parser. If it's in the translation bits on our side, what do you think would be the least surprising behavior? Bignum?

@tarcieri

This comment has been minimized.

Show comment
Hide comment
@tarcieri

tarcieri Aug 17, 2009

Yes, Bignum would be fine. We're just round-tripping everything while doing some AST munging, so as long as what goes in comes out I don't really care what the intermediate representation is.

Yes, Bignum would be fine. We're just round-tripping everything while doing some AST munging, so as long as what goes in comes out I don't really care what the intermediate representation is.

@jbarnette

This comment has been minimized.

Show comment
Hide comment
@jbarnette

jbarnette Aug 17, 2009

Owner

Okay, Aaron and I are doing a quick round of blameshifting, and then we'll see what we can do about this. In the meantime, a patch (even if it's just a failing testcase) is most welcome. :)

Owner

jbarnette commented Aug 17, 2009

Okay, Aaron and I are doing a quick round of blameshifting, and then we'll see what we can do about this. In the meantime, a patch (even if it's just a failing testcase) is most welcome. :)

@ghost ghost assigned jbarnette Apr 13, 2011

@jbarnette

This comment has been minimized.

Show comment
Hide comment
@jbarnette

jbarnette Mar 28, 2015

Owner

I, uh, think I'll close this. ❤️

Owner

jbarnette commented Mar 28, 2015

I, uh, think I'll close this. ❤️

@jbarnette jbarnette closed this Mar 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment