New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace confirm, prompt with ConfirmDialog & PromptDialog #137

Merged
merged 9 commits into from Dec 29, 2014

Conversation

Projects
None yet
2 participants
@fasterthanlime
Contributor

fasterthanlime commented Dec 29, 2014

Cf. #136 for the rationale.

I guess what's missing now is an AlertDialog :)

I've tested (by hand) every case where a confirm / prompt dialog should appear, as far as I can tell, but double or triple-checking my code can't hurt.

At any rate, CATS is now a lot more usable on Linux now :)

@fasterthanlime

This comment has been minimized.

Contributor

fasterthanlime commented Dec 29, 2014

Also, I realize now that onConfirm, onSuccess, and onCancel could've been done as Qooxdoo events, but after trying for a half-hour to get a text field to span the full width of a dialog I was a bit sick of reading Qx docs :). Not too late to change though!

jbaron added a commit that referenced this pull request Dec 29, 2014

Merge pull request #137 from fasterthanlime/unstable
Replace confirm, prompt with ConfirmDialog & PromptDialog

@jbaron jbaron merged commit c6a8a6d into jbaron:unstable Dec 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jbaron

This comment has been minimized.

Owner

jbaron commented Dec 29, 2014

Thanks, seems to be also working fine on OSX. Now finally we have much more control on these popups, so in the future we can add more features to them if required to do so.

P.S Qx indeed has a steep learning curve. So I can relate to that feeling of spending too much time on the API pages of Qooxdoo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment