New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix bug with cache miss lookup for 'object' part of statement #39

Merged
merged 2 commits into from Jan 5, 2018

Conversation

Projects
None yet
2 participants
@tomsaleeba

tomsaleeba commented Dec 21, 2017

Firstly, thanks for the super useful plugin. I was seeing some weird behaviour when loading ~35 million triples where most relationships I looked at were wrong. They either pointed back to the same node or where they pointed to another node, it wasn't the right one.

I eventually traced it back to a cache miss and in the lookup, there was a typo that used the subject of the triple, not the object like it should.

I've committed a failing test and then the fix for it so you can verify.

Steps to reproduce:

  1. perform a load with the cache size set to lower than the number of triples to load (so we get cache misses)

Expected behaviour:
The loaded graph has the same relationships as the source RDF.

Actual behaviour:
Many relationships in the Neo4J graph don't mirror the RDF. They either point back to the same node (self relationship) or point to another, wrong node.

@tomsaleeba

This comment has been minimized.

Show comment
Hide comment
@tomsaleeba

tomsaleeba Dec 21, 2017

You can grab a binary of this fix at https://github.com/tomsaleeba/neosemantics/releases/tag/3.2.1.1-a5f67ab.

Edit: my PR has been merged, get the binary from this repo's releases: https://github.com/jbarrasa/neosemantics/releases/tag/3.3.0.2

tomsaleeba commented Dec 21, 2017

You can grab a binary of this fix at https://github.com/tomsaleeba/neosemantics/releases/tag/3.2.1.1-a5f67ab.

Edit: my PR has been merged, get the binary from this repo's releases: https://github.com/jbarrasa/neosemantics/releases/tag/3.3.0.2

@jbarrasa jbarrasa merged commit 9431ab7 into jbarrasa:master Jan 5, 2018

jbarrasa added a commit that referenced this pull request Jan 5, 2018

Merge pull request #39 from tomsaleeba/tomsaleeba-patch-2
Fix: fix bug with cache miss lookup for 'object' part of statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment