initial pass at refactoring filenames (JBIDE-16871) >> master #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've not reviewed it into details because it's too much change. I see this document is still using version2, version3 and other not-that-explicit variables. We should consider changing it to versionWithRespin and similar names, as it was done on some other documents. |
|
I'm actually strongly -1 for this change as the base document for Beta2 invalidates all the changes integrated by 3dfae28 |
…er email recipients)
|
Good call. Fixed in followup commit, just before you went away on Weekend O'Clock. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.