Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The assert can lead to dos. #519

Closed
zhouat opened this issue Jul 28, 2017 · 6 comments
Closed

The assert can lead to dos. #519

zhouat opened this issue Jul 28, 2017 · 6 comments

Comments

@zhouat
Copy link

zhouat commented Jul 28, 2017

The assert code can lead to a dos attack.

Trigger:

cat << EOF > file_poc
> !2
> EOF

build/util/parse file_poc

crash:

parse: /yaml/yaml-cpp/src/scanner.cpp:32: YAML::Token &YAML::Scanner::peek(): Assertion `!m_tokens.empty()' failed.
Aborted

@carnil
Copy link

carnil commented Aug 1, 2017

This issue has been assigned CVE-2017-11692

@Justinzobel
Copy link

@jbeder can we please see an update on this one also?

@hobbes1069
Copy link

Ping

@jbeder
Copy link
Owner

jbeder commented Dec 19, 2018

Is there a PR you'd like me to review?

@carnil
Copy link

carnil commented Jan 5, 2019

The issue is still present in abf941b FWIW (seen with a Debug build)

@jbeder
Copy link
Owner

jbeder commented Jan 21, 2020

Fixed by c946011

@jbeder jbeder closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants