Permalink
Commits on Dec 31, 2015
  1. test: inherit JOBS from environment

    In some virtualized environments the amount of available resources
    are misleading; for instance `multiprocessing.cpu_count()` on our current
    4-core smartos vm's returns `48`. This is not a bug, merely how the vm
    host provides information about available hardware.
    
    Avoid running into issues by overriding `cpu_count()` with `JOBS`.
    
    PR-URL: nodejs#4495
    Reviewed-By: Brian White <mscdex@mscdex.net>
    committed Dec 31, 2015
  2. test: improve assert message

    Improves the message when an assertion fires in the
    test-net-pipe-connect-errors so that it indicates the incorrect value
    received rather than merely reporting that the value is incorrect.
    
    PR-URL: nodejs#4461
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Trott committed Dec 29, 2015
Commits on Dec 30, 2015
  1. node: improve performance of process.hrtime()

    Move argument validation out of C++ and into JS. Improves performance
    by about 15-20%.
    
    PR-URL: nodejs#4484
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    evanlucas committed Dec 30, 2015
  2. test: shorten path for bogus socket

    This fixes CI failures for test-net-pipe-connect-errors on Raspberry Pi
    devices.
    
    PR-URL: nodejs#4478
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott committed with jasnell Dec 30, 2015
  3. doc: mention that http.Server inherits from net.Server

    PR-URL: nodejs#4455
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ryansobol committed with jasnell Dec 28, 2015
  4. doc: explain ClientRequest#setTimeout time unit

    State a time unit for the timeout parameter in ClientRequest#setTimeout
    
    PR-URL: nodejs#4458
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bripkens committed with jasnell Dec 28, 2015
  5. doc: fix spelling error in lib/url.js comment

    PR-URL: nodejs#4390
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nikolas committed with jasnell Dec 22, 2015
  6. util: faster arrayToHash

    The `util.format()` is used frequently, make the method faster
    is better.
    
    R-URL: nodejs#3964
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    JacksonTian committed with jasnell Nov 22, 2015
  7. doc: add anchors for _transform _flush _writev in stream.markdown

    PR-URL: nodejs#4448
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    iamchenxin committed with jasnell Dec 28, 2015
  8. test: fix race condition in test-http-client-onerror

    Occasionally test-http-client-onerror will fail with a refused connection.
    This patch fixes the possibility that connections will be attempted before
    server is listening.
    
    PR-URL: nodejs#4346
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    dnakamura committed with jasnell Dec 18, 2015
  9. test: remove unused assert module imports

    Many test modules load assert but do not use it. This change removes
    those instances.
    
    It also removes a handful of other unused variables when they were
    nearby.
    
    PR-URL: nodejs#4438
    Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott committed with jasnell Dec 27, 2015
  10. doc: improvements to debugger.markdown copy

    General improvements to debugger.markdown
    
    PR-URL: nodejs#4436
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    jasnell committed Dec 27, 2015
  11. http: use `self.keepAlive` instead of `self.options.keepAlive`

    In http.agent, all other options are directly accessed through
    `self.` not `self.options`.
    
    PR-URL: nodejs#4407
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    dschenkelman committed with jasnell Dec 23, 2015
  12. doc: improvements to events.markdown copy

    General improvements to events.markdown copy including a
    bit of restructuring and improved examples
    
    PR-URL: nodejs#4468
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    jasnell committed Dec 29, 2015
  13. doc: improvements to dns.markdown copy

    General improvements to dns.markdown copy and examples
    
    PR-URL: nodejs#4449
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    jasnell committed Dec 27, 2015
  14. doc: improvements to console.markdown copy

    Several improvements including a few new examples
    
    PR-URL: nodejs#4428
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    jasnell committed Dec 26, 2015
  15. doc: improve child_process.markdown copy

    General improvements to child_process.markdown
    
    PR-URL: nodejs#4383
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    jasnell committed Dec 21, 2015
  16. http: fix non-string header value concatenation

    Since headers are stored in an empty literal object ({}) instead
    of an object created with Object.create(null), care must be taken
    with property names inherited from Object. Currently there are
    only functions inherited, so we can safely check for existing
    strings instead.
    
    Fixes: nodejs#4456
    PR-URL: nodejs#4460
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
    mscdex committed Dec 28, 2015
  17. test: don't use cwd for relative path

    With the introduction of temporary paths in the test runner
    realpath tests would bail in scenarios where the temporary folder
    wasn't in the same directory as the source code.
    
    PR-URL: nodejs#4477
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    committed Dec 30, 2015
  18. test: don't assume a certain folder structure

    A few tests assumed that temp dirs always lived in the same
    parent folder as fixtures. Make these use `common.tmpDir` instead.
    
    PR-URL: nodejs#3325
    Reviewed-By: Joao Reis <reis@janeasystems.com>
    committed Dec 30, 2015
  19. test: make temp path customizable

    In CI we previously passed `NODE_COMMON_PIPE` to the test runner to
    avoid long filenames. Add an option to the test runner that allows the
    user to change the temporary directory instead. This also allows us to
    run test suites in parallel since `NODE_COMMON_PIPE` otherwise would
    have been used from multiple tests at the same time.
    
    PR-URL: nodejs#3325
    Reviewed-By: Joao Reis <reis@janeasystems.com>
    committed Oct 12, 2015
  20. doc: copyedit setTimeout() documentation

    Copyedit the documentation for setTimeout() and enforce wrapping at 80
    characters in the markdown file for nearby text.
    
    PR-URL: nodejs#4434
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
    Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
    Trott committed Dec 27, 2015
  21. test: extend timeout in Debug mode

    Debug mode slows execution speed. There is work afoot to enable Debug
    mode runs on the continuous integration infrastructure for the project.
    Some tests are timing out, such as test-net-GH-5504.js.
    
    This change doubles the timeout returned from `common.platformTimeout()`
    when running in Debug mode. It also removes an unused variable from the
    aforementioned test-net-GH-5504.js.
    
    PR-URL: nodejs#4431
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Trott committed Dec 26, 2015
  22. doc: fix formatting in process.markdown

    All the other properties get an h2/## but process.connected gets an
    h3/### for no discernible reason. Change it to h2/## like the others.
    
    PR-URL: nodejs#4433
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
    Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
    Trott committed Dec 27, 2015
Commits on Dec 29, 2015
  1. tools: run tick processor without forking

    Using the tick processor no longer creates temporary files or spawns a
    child process.
    
    PR-URL: nodejs#4224
    Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
    matthewloring committed with ofrobots Dec 9, 2015
  2. test: remove unused variables from net tests

    Remove a handful of variables that are declared but never used in the
    tests for the net module.
    
    PR-URL: nodejs#4430
    Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott committed Dec 26, 2015
  3. test: remove unused vars in ChildProcess tests

    In addition to removing unused vars, this also fixes an instance where
    booleans were set presumably to check something but then never used.
    This now confirms that the events that were setting the booleans are
    fired.
    
    PR-URL: nodejs#4425
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott committed Dec 26, 2015
  4. test: fix flaky cluster-disconnect-race

    On single core Windows systems, process.send() would cause an
    EPIPE because of the ordering of the IPC channel disconnect and
    the process.send().
    
    The test was originally only relevant for non-Windows platforms,
    so this commit merely skips the test on Windows.
    
    Fixes: nodejs#4450
    PR-URL: nodejs#4457
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mscdex committed Dec 28, 2015
  5. test: fix flaky cluster-net-send

    Before this commit, it was possible on Windows for the server's
    'connection' handler to be called *after* the client socket's
    'connect' handler. This caused the 'message' event to be missed
    and the test would never end (timing out in CI). This problem
    was more easily reproducible on a low resource (slow CPU)
    Windows (2012r2) installation.
    
    This commit waits until both handlers have been called before
    sending the handle to the master process.
    
    Fixes: nodejs#3957
    PR-URL: nodejs#4444
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mscdex committed Dec 28, 2015
  6. test: fix flaky child-process-fork-regr-gh-2847

    Windows would die with ECONNRESET most times when running
    this particular test. This commit makes handling these errors
    more tolerable.
    
    PR-URL: nodejs#4442
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mscdex committed Dec 27, 2015
  7. test: remove unused variables from HTTPS tests

    PR-URL: nodejs#4426
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Trott committed Dec 26, 2015
  8. test: remove unused variables from TLS tests

    Some of the TLS tests have variables that do not get used. This removes
    those variables.
    
    PR-URL: nodejs#4424
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Trott committed Dec 26, 2015
  9. test: remove unused variables form http tests

    The http tests seem especially prone to including unused variables.
    This change removes them.
    
    PR-URL: nodejs#4422
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Trott committed Dec 25, 2015
Commits on Dec 28, 2015
  1. doc: catch the WORKING_GROUPS.md bootstrap docs up to date

    * Link to the separate CODE_OF_CONDUCT.md file in nodejs/node
    * Link to the ModerationPolicy.md file in nodejs/TSC
    
    PR-URL: nodejs#4367
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    jasnell committed Dec 20, 2015
  2. doc: improve assert.markdown copy

    General improvements to assert.markdown copy including
    new and improved examples
    
    PR-URL: nodejs#4360
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    jasnell committed Dec 20, 2015