Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support for library projects. #73

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
Collaborator

appamatto commented Oct 14, 2011

Using the --non-constant-id option to aapt we make sure that the
library projects' ids are not inlined by the compiler.
Unfortunately we need to several R.java files, each identical but with
different packages, since the library projects will be looking for them there.

Thanks to rst--this code is based on his but uses a different method.

You need to set isLibraryProject in Android := true for all of the library projects. Only direct dependencies are included, but it is now safe to flatten your dependency tree because all of the compilation occurs in the parent project.

rst commented Oct 15, 2011

Thanks. Looks good --- unfortunately, I can't kick the tires right now,
but I'll do that on Sunday.

Just as a heads-up to all concerned, the aapt tasks are also tweaked
by jbrechtel's pull request 71 (which puts the args in a Seq so directory
names with spaces work right), and with the code on Jan's own
refactor-manifest branch (which changes manifest path handling a bit).

Collaborator

appamatto commented Oct 21, 2011

Has anyone gotten a chance to look at this? I've been living on it for a while and it seems to be working so far.

Macarse commented Nov 12, 2011

appamatto: Does it work with the new SDK?

Collaborator

appamatto commented Nov 12, 2011

I'm not sure. I'm still on r13 because one of the library projects I depend on seemed to depend on it.

Owner

jberkel commented Nov 15, 2011

Any chance you could test this on r15 and resubmit the current pull request so it applies cleanly?

Collaborator

appamatto commented Nov 28, 2011

oops, that last submit was a mistake. I'll reapply the patch and submit a new pull request later.

@appamatto appamatto closed this Nov 28, 2011

What happened to this? Did any of this get into a recent version?

Owner

jberkel commented Feb 24, 2012

no it never got included, would be great to have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment