From 7f04e8477a9c65022005c4282eac80647cb957bc Mon Sep 17 00:00:00 2001 From: Anton Keks Date: Sat, 29 Aug 2015 12:48:22 +0300 Subject: [PATCH] extract method to make intention more clear --- .../com/zegoggles/smssync/service/RestoreTask.java | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/zegoggles/smssync/service/RestoreTask.java b/src/main/java/com/zegoggles/smssync/service/RestoreTask.java index 8901383a5..5a28b7126 100644 --- a/src/main/java/com/zegoggles/smssync/service/RestoreTask.java +++ b/src/main/java/com/zegoggles/smssync/service/RestoreTask.java @@ -121,9 +121,7 @@ private RestoreState restore(RestoreConfig config) { service.clearCache(); } } - if (smsIds.size() > 0) { - updateAllThreads(); - } + updateAllThreadsIfAnySmsRestored(); } else { Log.d(TAG, "nothing to restore"); } @@ -140,9 +138,7 @@ private RestoreState restore(RestoreConfig config) { return transition(ERROR, e); } catch (MessagingException e) { Log.e(TAG, "error", e); - if (smsIds.size() > 0) { - updateAllThreads(); - } + updateAllThreadsIfAnySmsRestored(); return transition(ERROR, e); } catch (IllegalStateException e) { // usually memory problems (Couldn't init cursor window) @@ -324,6 +320,12 @@ private boolean smsExists(ContentValues values) { return exists; } + private void updateAllThreadsIfAnySmsRestored() { + if (smsIds.size() > 0) { + updateAllThreads(); + } + } + private void updateAllThreads() { // thread dates + states might be wrong, we need to force a full update // unfortunately there's no direct way to do that in the SDK, but passing a