Use the original stacktrace, not a new one. #144

Merged
merged 1 commit into from Nov 5, 2013

3 participants

@Therzok

Throwing that specific exception will change the stacktrace to point at the new exception point, instead of the original.

I'm not sure if it was intended or not.

@jbevain
Owner

This seems to directly contradict the comment above.

@Therzok

Oh, you're right. One second, force pushing the right fix.

@Therzok

The thing is, if we want to throw the original, we do an empty catch and put throw; in the outer catch.

@Therzok Therzok Throwing that specific exception will change the stacktrace to point …
…at the new exception point, instead of the original.
98ba6c7
@Therzok

Fixed.

@Therzok

throw ce; would make the stacktrace point at the inner catch, whilst disregarding old stacktrace.

@jbevain
Owner

@spouliot, a word on this maybe?

@spouliot

Sounds right. We want the right exception but having the correct stack trace is better. I'll look into fixing this in the original (mono) source.

@jbevain jbevain merged commit 8425de4 into jbevain:master Nov 5, 2013
@jbevain
Owner

Sounds great, thanks guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment