Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it compile with latest changes (with netstandard1.5) #269

Closed
wants to merge 1 commit into from

Conversation

matthid
Copy link

@matthid matthid commented Apr 30, 2016

No description provided.

@jbevain
Copy link
Owner

jbevain commented May 3, 2016

This looks pretty good, thanks @matthid!

A few things:

  • Is the NuGet.config necessary?
  • I'd rather be specific about what we include compared to what we exclude for the sources.
  • Can we use wildcards for package versions of BCL stuff for the .NET standard?
  • Why .NET Standard 1.5? Can't we use a smaller one?

@matthid
Copy link
Author

matthid commented May 3, 2016

Yep the config is required as those packages are not on nuget. The fsharp one might not be required...

Dont know about wildcards, they didn't worked when I tried them.

We can probably use a smaller one but 1.5 is fine for me.

Sent from my iPhone

On 03 May 2016, at 22:24, Jb Evain notifications@github.com wrote:

This looks pretty good, thanks @matthid!

A few things:

Is the NuGet.config necessary?
I'd rather be specific about what we include compared to what we exclude for the sources.
Can we use wildcards for package versions of BCL stuff for the .NET standard?
Why .NET Standard 1.5? Can't we use a smaller one?

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@matthid matthid mentioned this pull request Jun 26, 2016
58 tasks
matthid added a commit to matthid/FAKE that referenced this pull request Jun 26, 2016
… run with net46 and compile for netcoreapp1.0
matthid added a commit to matthid/FAKE that referenced this pull request Jul 1, 2016
… run with net46 and compile for netcoreapp1.0
matthid added a commit to matthid/FAKE that referenced this pull request Jul 12, 2016
… run with net46 and compile for netcoreapp1.0
matthid added a commit to matthid/FAKE that referenced this pull request Jul 13, 2016
… run with net46 and compile for netcoreapp1.0
matthid added a commit to matthid/FAKE that referenced this pull request Jul 17, 2016
… run with net46 and compile for netcoreapp1.0
@jbevain
Copy link
Owner

jbevain commented Jul 18, 2016

Thanks, I pushed a slightly different update to the branch.

@jbevain jbevain closed this Jul 18, 2016
matthid added a commit to matthid/FAKE that referenced this pull request Jul 22, 2016
… run with net46 and compile for netcoreapp1.0
matthid added a commit to matthid/FAKE that referenced this pull request Jul 24, 2016
… run with net46 and compile for netcoreapp1.0
matthid added a commit to matthid/FAKE that referenced this pull request Jul 30, 2016
… run with net46 and compile for netcoreapp1.0
matthid added a commit to matthid/FAKE that referenced this pull request Mar 9, 2018
… run with net46 and compile for netcoreapp1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants