New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging fixes, SenderProtocol fixes #12

Merged
merged 3 commits into from May 20, 2016

Conversation

Projects
None yet
2 participants
@mikemol

mikemol commented May 20, 2016

Fixed crash when hitting a deprecated use of send().

Fixed SenderProtocol's static initialization of _config, which was causing all SenderProtocol-derived classes to behave as a singleton.

mikemol added some commits May 20, 2016

Fix singleton behavior of SenderProtocol
SenderProtocol was using a statically-defined dict to initialize
its member data. That meant that any change to configuration
changed configuration for *all* instances, making it impossible to,
say, have separate instances of DataContainer for LLD and items.

@mikemol mikemol referenced this pull request May 20, 2016

Closed

Fixes #11

@jbfavre jbfavre merged commit 7a15ec6 into jbfavre:dev May 20, 2016

@jbfavre

This comment has been minimized.

Owner

jbfavre commented May 20, 2016

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment