Multiple improvements listed below #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jktomer
commented
Jan 16, 2022
•
jktomer
commented
- pge: write temp files with .pdf extension (formerly pge: write temp files with .pdf extension #51)
- pass overwrite flag to atomic_write (formerly pass overwrite to atomic_write #56)
- utlipro: wait for page to load when clicking download link (formerly bug(ultipro_google): wait for page load after clicking download link #63) (fixes ultipro_google fails with "element not interactable" #22)
|
Failures are odd, look like some problem with the test environment setup? Am I able to rerun them myself? |
|
Yeah I don't understand the mypy cache folder issue. I deleted mine but mypy still succeeded. I don't see a way to approve you for automatic builds. |
|
@jbms, you might have a better idea how the testing environment is set up, and why I have the same mypy version and for me |
jbms
added a commit
that referenced
this pull request
Jan 20, 2022
This is intended to address the CI failure observed in #64.
jbms
added a commit
that referenced
this pull request
Jan 20, 2022
This is intended to address the CI failure observed in #64.
|
@jktomer, the build should succeed now after a rebase. |
Google Drive otherwise seems to get confused about their type in a way that is not fixed with a rename later
I need this because I keep my finance-dl data in Google Drive mounted with google-drive-fuse, and it doesn't support the operation atomic_write does without it. (With overwrite=True, atomicwrites does a rename; otherwise it does a link followed by an unlink. google-drive-fuse supports rename just fine, but not hard links.) The real solution is probably to fix atomicwrites to properly support all filesystems that don't support links instead of just Windows, but this is less work.
|
Aha—it doesn't pass, but it does fail more interestingly! Fixed; I have no idea why it passes on my machine... |
|
mergeable now I think? |
Zburatorul
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.