Added PDF support. #2

Merged
merged 2 commits into from Sep 28, 2012

Conversation

Projects
None yet
2 participants
@robbrit
Contributor

robbrit commented Sep 28, 2012

FreshBooks added the invoice.getPDF command, which returns binary PDF data instead of XML. I changed the library to handle the case when PDF data is sent from FreshBooks and will handle it accordingly.

@jboesch

This comment has been minimized.

Show comment
Hide comment
@jboesch

jboesch Sep 28, 2012

Thanks for doing this. Can you please adjust the code to follow the same standard as the file. Example 4 spaces for indentation, curly braces on new line for if/else.

Thanks for doing this. Can you please adjust the code to follow the same standard as the file. Example 4 spaces for indentation, curly braces on new line for if/else.

lib/FreshBooksRequest.php
@@ -145,7 +145,7 @@ public function getGeneratedXML()
/*
* Send the request over the wire
*
- * @return array
+ * @return binary data if response is a PDF, array if not

This comment has been minimized.

@robbrit

This comment has been minimized.

Show comment
Hide comment
@robbrit

robbrit Sep 28, 2012

Contributor

Alright, good to go. Let me know if there's any other tweaks that should be done.

Contributor

robbrit commented Sep 28, 2012

Alright, good to go. Let me know if there's any other tweaks that should be done.

jboesch pushed a commit that referenced this pull request Sep 28, 2012

@jboesch jboesch merged commit b8d58a9 into jboesch:master Sep 28, 2012

@jboesch

This comment has been minimized.

Show comment
Hide comment
@jboesch

jboesch Sep 28, 2012

Owner

Looks great! Thank you for doing this :)

Owner

jboesch commented Sep 28, 2012

Looks great! Thank you for doing this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment