AS7-5265 EJB timer - @Schedule and @Timer #317

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@OndraZizka
Contributor

OndraZizka commented Jul 28, 2012

No description provided.

@pmuir

View changes

ejb-timer/README.md
+wicket-war: Wicket Framework used in a WAR.
+===========================================
+Author: Ondrej Zizka <ozizka@redhat.com>
+Level: Basic

This comment has been minimized.

@pmuir

pmuir Jul 30, 2012

Contributor

Should be "Beginner" :-)

@pmuir

pmuir Jul 30, 2012

Contributor

Should be "Beginner" :-)

This comment has been minimized.

@OndraZizka

OndraZizka Jul 31, 2012

Contributor

I will change this, as well as remove notions of Wicket (result of copy-paste)

@OndraZizka

OndraZizka Jul 31, 2012

Contributor

I will change this, as well as remove notions of Wicket (result of copy-paste)

This comment has been minimized.

@OndraZizka

OndraZizka Aug 6, 2012

Contributor

Done

@OndraZizka

OndraZizka Aug 6, 2012

Contributor

Done

@pmuir

View changes

ejb-timer/README.md
+
+ mvn clean package jboss-as:deploy
+
+4. This will deploy `target/jboss-as-wicket-war.war` to the running instance of the server.

This comment has been minimized.

@pmuir

pmuir Jul 30, 2012

Contributor

Needs an update :-)

@pmuir

pmuir Jul 30, 2012

Contributor

Needs an update :-)

This comment has been minimized.

@OndraZizka

OndraZizka Aug 6, 2012

Contributor

Done

@OndraZizka

OndraZizka Aug 6, 2012

Contributor

Done

@pmuir

View changes

...imer/src/main/java/org/jboss/as/quickstarts/ejbTimer/TimeoutExample.java
+
+ @Timeout
+ public void scheduler(Timer timer) {
+ System.out.println("SingletonTimer: Info="+timer.getInfo());

This comment has been minimized.

@pmuir

pmuir Jul 30, 2012

Contributor

Some more spaces might be nice here.

@pmuir

pmuir Jul 30, 2012

Contributor

Some more spaces might be nice here.

This comment has been minimized.

@OndraZizka

OndraZizka Aug 6, 2012

Contributor

Done

@OndraZizka

OndraZizka Aug 6, 2012

Contributor

Done

@pmuir

View changes

ejb-timer/src/main/webapp/WEB-INF/web.xml
+ <env-entry-value>Welcome to the JBoss AS Quickstart showing the use of Wicket, packaged in an EAR</env-entry-value>
+ </env-entry>
+
+</web-app>

This comment has been minimized.

@pmuir

pmuir Jul 30, 2012

Contributor

Do we need this file at all?

@pmuir

pmuir Jul 30, 2012

Contributor

Do we need this file at all?

This comment has been minimized.

@OndraZizka

OndraZizka Jul 31, 2012

Contributor

Nope :) I originally intended to make it a web app, but keeping web out keeps it much clearer.

@OndraZizka

OndraZizka Jul 31, 2012

Contributor

Nope :) I originally intended to make it a web app, but keeping web out keeps it much clearer.

This comment has been minimized.

@OndraZizka

OndraZizka Aug 6, 2012

Contributor

Done

@OndraZizka

OndraZizka Aug 6, 2012

Contributor

Done

@pmuir

View changes

ejb-timer/src/main/webapp/WEB-INF/ejb-timer-quickstart-ds.xml
+ </security>
+ </datasource>
+</datasources>
+

This comment has been minimized.

@pmuir

pmuir Jul 30, 2012

Contributor

Probable we don't need a DS at all?

@pmuir

pmuir Jul 30, 2012

Contributor

Probable we don't need a DS at all?

This comment has been minimized.

@OndraZizka

OndraZizka Jul 31, 2012

Contributor

Regarding DS - I thought it might be necessary for persistent timeouts. But that's probably only true for AS 5 and 6, right? AS 7 puts this to files?

@OndraZizka

OndraZizka Jul 31, 2012

Contributor

Regarding DS - I thought it might be necessary for persistent timeouts. But that's probably only true for AS 5 and 6, right? AS 7 puts this to files?

This comment has been minimized.

@pmuir

pmuir Aug 3, 2012

Contributor

I think the app server will just use it's own persistent store for that, not one you define.

@pmuir

pmuir Aug 3, 2012

Contributor

I think the app server will just use it's own persistent store for that, not one you define.

This comment has been minimized.

@OndraZizka

OndraZizka Aug 6, 2012

Contributor

Removed

@OndraZizka

OndraZizka Aug 6, 2012

Contributor

Removed

@pmuir

View changes

ejb-timer/src/main/webapp/WEB-INF/beans.xml
+ xsi:schemaLocation="
+ http://java.sun.com/xml/ns/javaee
+ http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
+</beans>

This comment has been minimized.

@pmuir

pmuir Jul 30, 2012

Contributor

Does this use CDI?

@pmuir

pmuir Jul 30, 2012

Contributor

Does this use CDI?

This comment has been minimized.

@OndraZizka

OndraZizka Jul 31, 2012

Contributor

I am so messy. Will fix.

@OndraZizka

OndraZizka Jul 31, 2012

Contributor

I am so messy. Will fix.

This comment has been minimized.

@OndraZizka

OndraZizka Aug 6, 2012

Contributor

Done

@OndraZizka

OndraZizka Aug 6, 2012

Contributor

Done

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Jul 31, 2012

Contributor

Following the instructions in the README, I get a deployment errror. This is in the server log:

14:25:11,069 INFO [org.jboss.weld.deployer](MSC service thread 1-2) JBAS016005: Starting Services for CDI deployment: jboss-as-ejb-timer.war
14:25:11,093 INFO [org.jboss.as.connector.subsystems.datasources](MSC service thread 1-1) JBAS010400: Bound data source [jboss/datasources/EjbTimerQuickstartDS]
14:25:11,228 INFO [org.jboss.as.server](management-handler-thread - 2) JBAS015870: Deploy of deployment "jboss-as-ejb-timer.war" was rolled back with failure message {"JBAS014771: Services with missing/unavailable dependencies" => ["jboss.persistenceunit."jboss-as-ejb-timer.war#primary"jboss.naming.context.java.jboss.datasources.WicketQuickstartDSMissing[jboss.persistenceunit."jboss-as-ejb-timer.war#primary"jboss.naming.context.java.jboss.datasources.WicketQuickstartDS]"]}
14:25:11,237 INFO [org.jboss.as.connector.subsystems.datasources](MSC service thread 1-8) JBAS010409: Unbound data source [jboss/datasources/EjbTimerQuickstartDS]
14:25:11,251 INFO [org.jboss.as.server.deployment](MSC service thread 1-1) JBAS015877: Stopped deployment jboss-as-ejb-timer.war in 24ms
14:25:11,253 INFO [org.jboss.as.controller](management-handler-thread - 2) JBAS014774: Service status report
JBAS014775: New missing/unsatisfied dependencies:
service jboss.naming.context.java.jboss.datasources.WicketQuickstartDS (missing) dependents: [service jboss.persistenceunit."jboss-as-ejb-timer.war#primary

As Pete suggested, maybe the datasource isn't needed?

Contributor

sgilda commented Jul 31, 2012

Following the instructions in the README, I get a deployment errror. This is in the server log:

14:25:11,069 INFO [org.jboss.weld.deployer](MSC service thread 1-2) JBAS016005: Starting Services for CDI deployment: jboss-as-ejb-timer.war
14:25:11,093 INFO [org.jboss.as.connector.subsystems.datasources](MSC service thread 1-1) JBAS010400: Bound data source [jboss/datasources/EjbTimerQuickstartDS]
14:25:11,228 INFO [org.jboss.as.server](management-handler-thread - 2) JBAS015870: Deploy of deployment "jboss-as-ejb-timer.war" was rolled back with failure message {"JBAS014771: Services with missing/unavailable dependencies" => ["jboss.persistenceunit."jboss-as-ejb-timer.war#primary"jboss.naming.context.java.jboss.datasources.WicketQuickstartDSMissing[jboss.persistenceunit."jboss-as-ejb-timer.war#primary"jboss.naming.context.java.jboss.datasources.WicketQuickstartDS]"]}
14:25:11,237 INFO [org.jboss.as.connector.subsystems.datasources](MSC service thread 1-8) JBAS010409: Unbound data source [jboss/datasources/EjbTimerQuickstartDS]
14:25:11,251 INFO [org.jboss.as.server.deployment](MSC service thread 1-1) JBAS015877: Stopped deployment jboss-as-ejb-timer.war in 24ms
14:25:11,253 INFO [org.jboss.as.controller](management-handler-thread - 2) JBAS014774: Service status report
JBAS014775: New missing/unsatisfied dependencies:
service jboss.naming.context.java.jboss.datasources.WicketQuickstartDS (missing) dependents: [service jboss.persistenceunit."jboss-as-ejb-timer.war#primary

As Pete suggested, maybe the datasource isn't needed?

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Jul 31, 2012

Contributor

I got it to work by doing the following:

  • I removed the resources/ directory and its contents as you don't need the persistence.xml file.
  • I removed the webapp/WEB-INF/ejb-timer-quickstart-ds.xml file.

Removing the web.xml file resulted in the following error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.1.1:war (default-war) on project jboss-as-ejb-timer: Error assembling WAR: webxml attribute is required (or pre-existing WEB-INF/web.xml if executing in update mode) -> [Help 1]

I got around that by adding this plugin to the pom.xml build section:
<plugin> <artifactId>maven-war-plugin</artifactId> <version>2.1.1</version> <configuration> <!-- Java EE 6 doesn't require web.xml, Maven needs to catch up! --> <failOnMissingWebXml>false</failOnMissingWebXml> </configuration> </plugin>

Contributor

sgilda commented Jul 31, 2012

I got it to work by doing the following:

  • I removed the resources/ directory and its contents as you don't need the persistence.xml file.
  • I removed the webapp/WEB-INF/ejb-timer-quickstart-ds.xml file.

Removing the web.xml file resulted in the following error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.1.1:war (default-war) on project jboss-as-ejb-timer: Error assembling WAR: webxml attribute is required (or pre-existing WEB-INF/web.xml if executing in update mode) -> [Help 1]

I got around that by adding this plugin to the pom.xml build section:
<plugin> <artifactId>maven-war-plugin</artifactId> <version>2.1.1</version> <configuration> <!-- Java EE 6 doesn't require web.xml, Maven needs to catch up! --> <failOnMissingWebXml>false</failOnMissingWebXml> </configuration> </plugin>

@OndraZizka

This comment has been minimized.

Show comment
Hide comment
@OndraZizka

OndraZizka Aug 6, 2012

Contributor

I've reflected all comments and pushed the result.

Contributor

OndraZizka commented Aug 6, 2012

I've reflected all comments and pushed the result.

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Aug 13, 2012

Contributor

When I build and deploy this, I get BUILD FAILURE and this error in the server log:

10:33:47,348 INFO [org.jboss.as.server](management-handler-thread - 20) JBAS015870: Deploy of deployment "jboss-as-ejb-timer.war" was rolled back with failure message {"JBAS014771: Services with missing/unavailable dependencies" => ["jboss.persistenceunit."jboss-as-ejb-timer.war#primary"jboss.naming.context.java.jboss.datasources.WicketQuickstartDSMissing[jboss.persistenceunit."jboss-as-ejb-timer.war#primary"jboss.naming.context.java.jboss.datasources.WicketQuickstartDS]"]}
10:33:47,357 INFO [org.jboss.as.server.deployment](MSC service thread 1-2) JBAS015877: Stopped deployment jboss-as-ejb-timer.war in 8ms
10:33:47,358 INFO [org.jboss.as.controller](management-handler-thread - 20) JBAS014774: Service status report
JBAS014776: Newly corrected services:
service jboss.naming.context.java.jboss.datasources.WicketQuickstartDS (new available)

You removed the datasource, but I believe you also need to remove the persistence.xml file as well since it is not needed. It deploys fine when I remove it.

Also, would you mind squashing all the commits into one so it's easier to review? :-)

Contributor

sgilda commented Aug 13, 2012

When I build and deploy this, I get BUILD FAILURE and this error in the server log:

10:33:47,348 INFO [org.jboss.as.server](management-handler-thread - 20) JBAS015870: Deploy of deployment "jboss-as-ejb-timer.war" was rolled back with failure message {"JBAS014771: Services with missing/unavailable dependencies" => ["jboss.persistenceunit."jboss-as-ejb-timer.war#primary"jboss.naming.context.java.jboss.datasources.WicketQuickstartDSMissing[jboss.persistenceunit."jboss-as-ejb-timer.war#primary"jboss.naming.context.java.jboss.datasources.WicketQuickstartDS]"]}
10:33:47,357 INFO [org.jboss.as.server.deployment](MSC service thread 1-2) JBAS015877: Stopped deployment jboss-as-ejb-timer.war in 8ms
10:33:47,358 INFO [org.jboss.as.controller](management-handler-thread - 20) JBAS014774: Service status report
JBAS014776: Newly corrected services:
service jboss.naming.context.java.jboss.datasources.WicketQuickstartDS (new available)

You removed the datasource, but I believe you also need to remove the persistence.xml file as well since it is not needed. It deploys fine when I remove it.

Also, would you mind squashing all the commits into one so it's easier to review? :-)

@pmuir

This comment has been minimized.

Show comment
Hide comment
@pmuir

pmuir Oct 15, 2012

Contributor

@OndraZizka just a quick status check

Contributor

pmuir commented Oct 15, 2012

@OndraZizka just a quick status check

@OndraZizka

This comment has been minimized.

Show comment
Hide comment
@OndraZizka

OndraZizka Oct 17, 2012

Contributor

Ah, right... I will fix this during this week, hopefully.

Contributor

OndraZizka commented Oct 17, 2012

Ah, right... I will fix this during this week, hopefully.

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Dec 17, 2012

Contributor

20121217: Sent email reminder.

Contributor

sgilda commented Dec 17, 2012

20121217: Sent email reminder.

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Apr 9, 2013

Contributor

2013-04-09: At the time we last talked, this only had a minor issue to remove the persistence.xml file and squash the commits.

I ran the QS Tools report and believe the only other changes required are the following:

  • Add the following metadata to the README.md file:

    Target Product: EAP
    Source: <https://github.com/jboss-jdf/jboss-as-quickstart/>
    
  • Make sure the licenses match the license template in the root of the quickstart directory.

Contributor

sgilda commented Apr 9, 2013

2013-04-09: At the time we last talked, this only had a minor issue to remove the persistence.xml file and squash the commits.

I ran the QS Tools report and believe the only other changes required are the following:

  • Add the following metadata to the README.md file:

    Target Product: EAP
    Source: <https://github.com/jboss-jdf/jboss-as-quickstart/>
    
  • Make sure the licenses match the license template in the root of the quickstart directory.

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Apr 26, 2013

Contributor

@OndraZizka : Just checking in to see how things are going with your quickstart. Please let me know when it's ready for review again.

Contributor

sgilda commented Apr 26, 2013

@OndraZizka : Just checking in to see how things are going with your quickstart. Please let me know when it's ready for review again.

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda May 8, 2013

Contributor

@OndraZizka : Just checking on the status of this quickstart. :-)

Contributor

sgilda commented May 8, 2013

@OndraZizka : Just checking on the status of this quickstart. :-)

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Aug 2, 2013

Contributor

@OndraZizka thinks this will be a quick fix and hopes to finish it up in the next week.

Contributor

sgilda commented Aug 2, 2013

@OndraZizka thinks this will be a quick fix and hopes to finish it up in the next week.

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Aug 19, 2013

Contributor

Sent email to @OndraZizka to let him know we will be closing pull requests in a few days to reorganize the quickstarts, so this needs to be finished ASAP.

Contributor

sgilda commented Aug 19, 2013

Sent email to @OndraZizka to let him know we will be closing pull requests in a few days to reorganize the quickstarts, so this needs to be finished ASAP.

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Aug 21, 2013

Contributor

Since I haven't had a response from Ondra, I will close this one for now. He can repen it at a later date.

Contributor

sgilda commented Aug 21, 2013

Since I haven't had a response from Ondra, I will close this one for now. He can repen it at a later date.

@sgilda sgilda closed this Aug 21, 2013

@sgilda sgilda reopened this Aug 21, 2013

@OndraZizka

This comment has been minimized.

Show comment
Hide comment
@OndraZizka

OndraZizka Aug 23, 2013

Contributor

Now it should be okay to merge.

Contributor

OndraZizka commented Aug 23, 2013

Now it should be okay to merge.

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Aug 23, 2013

Contributor

Thanks Ondra. I'll check it out next!

Contributor

sgilda commented Aug 23, 2013

Thanks Ondra. I'll check it out next!

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Aug 23, 2013

Contributor

@OndraZizka : There 41 files changed in your 6 commits. The first commit even says
Java source 1.6 for some quickstarts, mostly DeltaSpike

I believe you should only have 4 files committed for this quickstart. Can you clean up the commits so that only the ejb-timer source is included?

Also, can you run the QS tools utility on your quickstart? It's reporting some violations. Some are due to changes since you started this quickstart. See step 8 here: https://github.com/jboss-jdf/jboss-as-quickstart/blob/master/CONTRIBUTING.md

I did test the quickstart and it compiles, deploys, and works fine.

Contributor

sgilda commented Aug 23, 2013

@OndraZizka : There 41 files changed in your 6 commits. The first commit even says
Java source 1.6 for some quickstarts, mostly DeltaSpike

I believe you should only have 4 files committed for this quickstart. Can you clean up the commits so that only the ejb-timer source is included?

Also, can you run the QS tools utility on your quickstart? It's reporting some violations. Some are due to changes since you started this quickstart. See step 8 here: https://github.com/jboss-jdf/jboss-as-quickstart/blob/master/CONTRIBUTING.md

I did test the quickstart and it compiles, deploys, and works fine.

ejb-timer/README.md
+Level: Beginner
+Technologies: EJB 3.1 Timer
+Summary: Demonstrates how to use EJB 3.1 Timer (@Schedule and @Timeout) with the JBoss AS server.
+

This comment has been minimized.

@sgilda

sgilda Aug 23, 2013

Contributor

Please add the following:

Target Product: EAP
Source: https://github.com/jboss-jdf/jboss-as-quickstart/

@sgilda

sgilda Aug 23, 2013

Contributor

Please add the following:

Target Product: EAP
Source: https://github.com/jboss-jdf/jboss-as-quickstart/

This comment has been minimized.

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Can't get rid of Content for metadata [Source: = https://github.com/jboss-jdf/jboss-as-quickstart/] should follow the [<(http|https)://\w.*>] pattern

The other warnings are gone.

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Can't get rid of Content for metadata [Source: = https://github.com/jboss-jdf/jboss-as-quickstart/] should follow the [<(http|https)://\w.*>] pattern

The other warnings are gone.

ejb-timer/pom.xml
+ line below to use version 3.0.0.Final-redhat-1 which is a release certified
+ to work with JBoss EAP 6. It requires you have access to the JBoss EAP 6
+ maven repository. -->
+ <!-- <jboss.spec.version>3.0.0.Final-redhat-1</jboss.spec.version> -->

This comment has been minimized.

@sgilda

sgilda Aug 23, 2013

Contributor

These property names were changed and the versions have been updated. This section should now be:

    <version.jboss.spec.javaee.6.0>3.0.2.Final</version.jboss.spec.javaee.6.0>
    <!-- Alternatively, comment out the above line, and un-comment the 
        line below to use version 3.0.2.Final-redhat-3 which is a release certified 
        to work with JBoss EAP 6. It requires you have access to the JBoss EAP 6 
        maven repository. -->
    <!-- <version.jboss.spec.javaee.6.0>3.0.2.Final-redhat-3</version.jboss.spec.javaee.6.0> -->
@sgilda

sgilda Aug 23, 2013

Contributor

These property names were changed and the versions have been updated. This section should now be:

    <version.jboss.spec.javaee.6.0>3.0.2.Final</version.jboss.spec.javaee.6.0>
    <!-- Alternatively, comment out the above line, and un-comment the 
        line below to use version 3.0.2.Final-redhat-3 which is a release certified 
        to work with JBoss EAP 6. It requires you have access to the JBoss EAP 6 
        maven repository. -->
    <!-- <version.jboss.spec.javaee.6.0>3.0.2.Final-redhat-3</version.jboss.spec.javaee.6.0> -->

This comment has been minimized.

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Done

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Done

ejb-timer/pom.xml
+ <dependency>
+ <groupId>org.jboss.spec</groupId>
+ <artifactId>jboss-javaee-6.0</artifactId>
+ <version>${jboss.spec.version}</version>

This comment has been minimized.

@sgilda

sgilda Aug 23, 2013

Contributor
    <version>${version.jboss.spec.javaee.6.0}</version>
@sgilda

sgilda Aug 23, 2013

Contributor
    <version>${version.jboss.spec.javaee.6.0}</version>

This comment has been minimized.

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Done

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Done

ejb-timer/pom.xml
+ by applicable law or agreed to in writing, software distributed under the
+ License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
+ OF ANY KIND, either express or implied. See the License for the specific
+ language governing permissions and limitations under the License. -->

This comment has been minimized.

@sgilda

sgilda Aug 23, 2013

Contributor

This license text is out of date. You can copy it from one of he other quickstart POM files. It should be:

@sgilda

sgilda Aug 23, 2013

Contributor

This license text is out of date. You can copy it from one of he other quickstart POM files. It should be:

This comment has been minimized.

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Done

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Done

ejb-timer/pom.xml
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <!-- Define the version of JBoss' Java EE 6 APIs we want to import. -->
+ <jboss.spec.version>3.0.0.Final</jboss.spec.version>

This comment has been minimized.

@sgilda

sgilda Aug 23, 2013

Contributor

Before this line, define the maven plugin property here:

    <version.jboss.maven.plugin>7.3.Final</version.jboss.maven.plugin>
@sgilda

sgilda Aug 23, 2013

Contributor

Before this line, define the maven plugin property here:

    <version.jboss.maven.plugin>7.3.Final</version.jboss.maven.plugin>

This comment has been minimized.

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Done

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Done

ejb-timer/pom.xml
+ <plugin>
+ <groupId>org.jboss.as.plugins</groupId>
+ <artifactId>jboss-as-maven-plugin</artifactId>
+ <version>7.4.Final</version>

This comment has been minimized.

@sgilda

sgilda Aug 23, 2013

Contributor

We don't use hard-coded versions. Use the property:

    <version>${version.jboss.maven.plugin}</version>
@sgilda

sgilda Aug 23, 2013

Contributor

We don't use hard-coded versions. Use the property:

    <version>${version.jboss.maven.plugin}</version>

This comment has been minimized.

@OndraZizka

OndraZizka Aug 23, 2013

Contributor

Just for this one or any plugin?

@OndraZizka

OndraZizka Aug 23, 2013

Contributor

Just for this one or any plugin?

@@ -0,0 +1,21 @@
+

This comment has been minimized.

@sgilda

sgilda Aug 23, 2013

Contributor

This file is missing the license header.

@sgilda

sgilda Aug 23, 2013

Contributor

This file is missing the license header.

This comment has been minimized.

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Done

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Done

@@ -0,0 +1,44 @@
+

This comment has been minimized.

@sgilda

sgilda Aug 23, 2013

Contributor

This file is missing the license header.

@sgilda

sgilda Aug 23, 2013

Contributor

This file is missing the license header.

This comment has been minimized.

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Done

@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Done

@OndraZizka

This comment has been minimized.

Show comment
Hide comment
@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Regarding "Java source 1.6 for some quickstarts, mostly DeltaSpike", that's because those were unbuildable. They need the changes, otherwise fail to compile as Java 1.3 source format. But I'll remove these changes and offer as separate PR.

Contributor

OndraZizka commented Aug 24, 2013

Regarding "Java source 1.6 for some quickstarts, mostly DeltaSpike", that's because those were unbuildable. They need the changes, otherwise fail to compile as Java 1.3 source format. But I'll remove these changes and offer as separate PR.

@OndraZizka

This comment has been minimized.

Show comment
Hide comment
@OndraZizka

OndraZizka Aug 24, 2013

Contributor

Squashed to one commit. Removed DeltaSpike stuff.

Contributor

OndraZizka commented Aug 24, 2013

Squashed to one commit. Removed DeltaSpike stuff.

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Aug 26, 2013

Contributor

@OndraZizka : This looks much better. I'll review it tomorrow.

Contributor

sgilda commented Aug 26, 2013

@OndraZizka : This looks much better. I'll review it tomorrow.

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Aug 26, 2013

Contributor

@OndraZizka - This looks good. One minor issue is still reported by the QS tools utility. The URL for the 'Source:' metadata tag should be linkable: Source: <https://github.com/jboss-jdf/jboss-as-quickstart/>. I can fix what when I merge it.

@VineetReynolds will do a code review on this tomorrow and if he gives the word, I will merge.

Contributor

sgilda commented Aug 26, 2013

@OndraZizka - This looks good. One minor issue is still reported by the QS tools utility. The URL for the 'Source:' metadata tag should be linkable: Source: <https://github.com/jboss-jdf/jboss-as-quickstart/>. I can fix what when I merge it.

@VineetReynolds will do a code review on this tomorrow and if he gives the word, I will merge.

+ @PostConstruct
+ public void initialize( InvocationContext ctx ) {
+ ScheduleExpression se = new ScheduleExpression();
+ // Set schedule to every 10 seconds.

This comment has been minimized.

@VineetReynolds

VineetReynolds Aug 27, 2013

Member

The 'second' expression for the ScheduleExpressions is '0/3' which implies 'every 3 seconds starting at second 0' i.e. 0,3,6,9,...57,60 seconds. So this comment should not read 'every 10 seconds'. Maybe you could incorporate what I wrote in the previous sentence.

Otherwise this looks good.

@VineetReynolds

VineetReynolds Aug 27, 2013

Member

The 'second' expression for the ScheduleExpressions is '0/3' which implies 'every 3 seconds starting at second 0' i.e. 0,3,6,9,...57,60 seconds. So this comment should not read 'every 10 seconds'. Maybe you could incorporate what I wrote in the previous sentence.

Otherwise this looks good.

This comment has been minimized.

@OndraZizka

OndraZizka Aug 27, 2013

Contributor

Right. I changed to more frequent and forgot to change the comment. Changing.

@OndraZizka

OndraZizka Aug 27, 2013

Contributor

Right. I changed to more frequent and forgot to change the comment. Changing.

This comment has been minimized.

@OndraZizka

OndraZizka Aug 28, 2013

Contributor

// Set schedule to every 3 seconds (starting at second 0 of every minute).

@OndraZizka

OndraZizka Aug 28, 2013

Contributor

// Set schedule to every 3 seconds (starting at second 0 of every minute).

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Aug 28, 2013

Contributor

Made minor adjustments to fix new qstools issues and merged.

Contributor

sgilda commented Aug 28, 2013

Made minor adjustments to fix new qstools issues and merged.

@sgilda sgilda closed this Aug 28, 2013

@OndraZizka

This comment has been minimized.

Show comment
Hide comment
@OndraZizka

OndraZizka Aug 29, 2013

Contributor

I see, so the <...> brackets are meant literally... I thought it's JUnit's style string comparison. Get it.

Contributor

OndraZizka commented Aug 29, 2013

I see, so the <...> brackets are meant literally... I thought it's JUnit's style string comparison. Get it.

@sgilda

This comment has been minimized.

Show comment
Hide comment
@sgilda

sgilda Aug 29, 2013

Contributor

@OndraZizka : Are you referring to the change I made to the Source metadata URL?

Contributor

sgilda commented Aug 29, 2013

@OndraZizka : Are you referring to the change I made to the Source metadata URL?

@OndraZizka

This comment has been minimized.

Show comment
Hide comment
@OndraZizka

OndraZizka Aug 29, 2013

Contributor

Yes.

Contributor

OndraZizka commented Aug 29, 2013

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment