Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add the JBoss Negotiation Toolkit as a quickstart. #322

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

darranl commented Aug 1, 2012

Here is where I currently am with this quickstart, this pull requests is to gather some feedback rather than to be merged immediately.

Speaking with Pete we need to ensure we have the security dependencies covered in their own bom so the versions can be omitted from the pom for this quickstart.

@pmuir pmuir commented on the diff Aug 1, 2012

negotiation-toolkit/README.md
+
+_NOTE: The following build command assumes you have configured your Maven user settings. If you have not, you must include Maven setting arguments on the command line. See [Build and Deploy the Quickstarts](../README.md#buildanddeploy) for complete instructions and additional options._
+
+1. Make sure you have started the JBoss Server as described above.
+2. Open a command line and navigate to the root directory of this quickstart.
+3. Type this command to build and deploy the archive:
+
+ mvn clean package jboss-as:deploy
+
+4. This will deploy `target/jboss-negotiation-toolkit.war` to the running instance of the server.
+
+
+Access the application
+---------------------
+
+The application will be running at the following URL <http://localhost:8080/jboss-negotiation-toolkit/>.
@pmuir

pmuir Aug 1, 2012

Contributor

To be consistent with other quickstarts, I would propose we use jboss-as-negotiation-toolkit. WDYT? AIUI the toolkit is only relevant to JBoss AS anyway.

@darranl

darranl Aug 2, 2012

Contributor

We can if you want but this toolkit has been around since 2008 and has always been accessed as 'jboss-negotiation-toolkit' - that was the reason I kept the original context.

@pmuir

pmuir Aug 2, 2012

Contributor

Ok, I hadn't realised that.

@pmuir pmuir commented on the diff Aug 1, 2012

negotiation-toolkit/pom.xml
+
+ <!-- Import the Servlet API, we use provided scope as the API is included
+ in JBoss AS 7 -->
+ <dependency>
+ <groupId>org.jboss.spec.javax.servlet</groupId>
+ <artifactId>jboss-servlet-api_3.0_spec</artifactId>
+ <scope>provided</scope>
+ </dependency>
+
+
+ <!-- Additional Security Dependencies -->
+ <dependency>
+ <groupId>org.jboss.security</groupId>
+ <artifactId>jboss-negotiation-common</artifactId>
+ <version>2.2.1.Final</version>
+ <scope>provided</scope>
@pmuir

pmuir Aug 1, 2012

Contributor

Will all these artifacts always be the same version?

@darranl

darranl Aug 2, 2012

Contributor

The version will increment over time but yes these will always remain in synch.

@pmuir

pmuir Aug 2, 2012

Contributor

Ok. That's easy to extract to a BOM. Will do one today.

Contributor

pmuir commented Aug 1, 2012

The bits I understand all look fine :-)

Contributor

darranl commented Aug 2, 2012

Just added a couple of my own comments, we could argue both ways re the name of the web app but if you want consistency for the long term going forward I am not set against changing it.

Contributor

pmuir commented Aug 2, 2012

I'm not sure on the web app name. Is there a way to bind to both?

Contributor

darranl commented Aug 2, 2012

I think only if we put it in an ear and deploy it twice !!

Contributor

darranl commented Aug 2, 2012

Actually if you don't mind lets keep the name as it is - I am working to re-vamp the Kerberos support in general in AS 7.2 as the existing implementation is very much based around the architecture of the older AS releases - this work will cause the toolkit or a toolkit to be re-visited in the quickstarts, that can then follow the new name.

Contributor

pmuir commented Aug 2, 2012

Sounds good. We also use a different name for h2-console, which is this is most akin to.

Contributor

sgilda commented Aug 2, 2012

I just tried to build this and ran into the following problem. I also wiped out my repository and tried again, with no luck.

$ mvn clean package
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building JBoss AS Quickstarts: negotiation-toolkit 7.1.2-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[WARNING] The POM for org.jboss.security:jboss-negotiation-common:jar:2.2.1.Final is missing, no dependency information available
[WARNING] The POM for org.jboss.security:jboss-negotiation-extras:jar:2.2.1.Final is missing, no dependency information available
[WARNING] The POM for org.jboss.security:jboss-negotiation-ntlm:jar:2.2.1.Final is missing, no dependency information available
[WARNING] The POM for org.jboss.security:jboss-negotiation-spnego:jar:2.2.1.Final is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.551s
[INFO] Finished at: Thu Aug 02 15:24:16 EDT 2012
[INFO] Final Memory: 3M/70M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project jboss-as-negotiation-toolkit: Could not resolve dependencies for project org.jboss.as.quickstarts:jboss-as-negotiation-toolkit:war:7.1.2-SNAPSHOT: The following artifacts could not be resolved: org.jboss.security:jboss-negotiation-common:jar:2.2.1.Final, org.jboss.security:jboss-negotiation-extras:jar:2.2.1.Final, org.jboss.security:jboss-negotiation-ntlm:jar:2.2.1.Final, org.jboss.security:jboss-negotiation-spnego:jar:2.2.1.Final: Failure to find org.jboss.security:jboss-negotiation-common:jar:2.2.1.Final in http://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException

Contributor

pmuir commented Aug 2, 2012

Ah yes, Darran, any issues getting org.jboss.security sync'd to central?

Basically, do you have a complex dependency tree that isn't in central yet?

On 2 Aug 2012, at 20:27, sgilda wrote:

I just tried to build this and ran into the following problem. I also wiped out my repository and tried again, with no luck.

$ mvn clean package
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building JBoss AS Quickstarts: negotiation-toolkit 7.1.2-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[WARNING] The POM for org.jboss.security:jboss-negotiation-common:jar:2.2.1.Final is missing, no dependency information available
[WARNING] The POM for org.jboss.security:jboss-negotiation-extras:jar:2.2.1.Final is missing, no dependency information available
[WARNING] The POM for org.jboss.security:jboss-negotiation-ntlm:jar:2.2.1.Final is missing, no dependency information available
[WARNING] The POM for org.jboss.security:jboss-negotiation-spnego:jar:2.2.1.Final is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.551s
[INFO] Finished at: Thu Aug 02 15:24:16 EDT 2012
[INFO] Final Memory: 3M/70M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project jboss-as-negotiation-toolkit: Could not resolve dependencies for project org.jboss.as.quickstarts:jboss-as-negotiation-toolkit:war:7.1.2-SNAPSHOT: The following artifacts could not be resolved: org.jboss.security:jboss-negotiation-common:jar:2.2.1.Final, org.jboss.security:jboss-negotiation-extras:jar:2.2.1.Final, org.jboss.security:jboss-negotiation-ntlm:jar:2.2.1.Final, org.jboss.security:jboss-negotiation-spnego:jar:2.2.1.Final: Failure to find org.jboss.security:jboss-negotiation-common:jar:2.2.1.Final in http://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException


Reply to this email directly or view it on GitHub:
jboss-jdf#322 (comment)

Contributor

darranl commented Aug 3, 2012

For JBoss Negotiation it is not something I have actually looked at yet what do I need to do to review that?

Dependency wise there is some dependency on JBoss Web, Picket Box and JBoss Common so would need to check that all of those can be available.

Before a synch occurs the toolkit should be removed from the negotiation build - I was waiting until this is complete before doing that but if it needs to go to central may need to remove it first and tag another release.

Contributor

pmuir commented Aug 3, 2012

Darran, I'll put you in contact with Joel @ Sonatype, who can help you with this.

Basically, you need to

a) have reasonably complete POMs (e.g. licensing info etc.). Joel can check this with a script.
b) have the transitive dependency tree in central. AFAIK this has to be manually checked still.

We can always put the quickstart in with the jboss repo in the POM for now, as long as we work to sort it out.

Contributor

darranl commented Aug 3, 2012

Sounds good, JBoss Negotiation is a quick build so will be easy to test in isolation.

Contributor

pmuir commented Oct 15, 2012

@darranl just a quick status check on this one?

Contributor

darranl commented Oct 16, 2012

Feel free to close this down for the moment, JBoss Negotiation toolkit has become one of my lower priority tasks at the moment - I have my branch so can resubmit it later after I have had a chance to get the maven central dependencies in line.

Contributor

sgilda commented Apr 26, 2013

@darranl : I know this is a low priority, but thought I'd check to see whether you will be working on this again. :-)

Contributor

darranl commented Apr 29, 2013

@sgilda Yes I will be working on this again, just need to find some time to review the requirements for being synced to central again - one of the dependencies I was waiting for how now been synced so I think I need to just add a workaround for the second one.

Contributor

sgilda commented Apr 29, 2013

@darranl : Thanks for the update. Let me know if there's anything I can do to help.

Contributor

sgilda commented Jul 29, 2013

Checked in with @darranl on July 29, 2012. He plans to continue working on it to make it compatible with Undertow.

Contributor

sgilda commented Aug 19, 2013

Spoke with Darran on IRC. He said we should close this pull and he will resubmit at a later time, after the reorganization of the quickstarts.

@sgilda sgilda closed this Aug 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment