Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Format ws #345

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

OndraZizka commented Oct 12, 2012

Fix helloworld-html5 pom.xml and whitespace formatting for few other pom.xmls
Basically, it's now aligned to JBoss 4-spaces standard.
Also, I fixed 2 poms which made QS uncompilable.

Contributor

sgilda commented Oct 12, 2012

Hi Ondra, would you mind squashing the commits to make it easier to see which files were changed at a glance? :-)
Thanks, Sande

Contributor

OndraZizka commented Oct 12, 2012

Hi Sande, GitHub does it for you. Click on the Files tab - that shows the aggregation of changes.
I have changed all pom.xml's.

Contributor

OndraZizka commented Oct 12, 2012

BTW there's one orphaned directory, IIRC it's carmart - it's not listed as module.

Contributor

sgilda commented Oct 13, 2012

Thanks Onrda. I learn something every day! :-)

@rafabene , are you aware of an orphaned directory in carmart?

@pmuir: Is it still preferable to squash the commits before merging, or is it not important?

Contributor

pmuir commented Oct 15, 2012

@OndraZizka did you push the html5 changes to aerogear as well?

Yes, it would be good to squash this all down in to one commit

Contributor

OndraZizka commented Oct 18, 2012

No, changed just here.
Ok i will squash it.

Contributor

sgilda commented Nov 2, 2012

@OndraZizka : Just a reminder that I'm waiting for these commits to be squashed. :-)

Contributor

OndraZizka commented Nov 5, 2012

It took me like an hour to squash so I hope its worth it.

Contributor

OndraZizka commented Nov 5, 2012

Not really buildable after squash. - gwthelloworld and erraihelloworld

Contributor

OndraZizka commented Nov 5, 2012

Fixed

Contributor

OndraZizka commented Nov 5, 2012

Squashed again :)

Contributor

sgilda commented Nov 12, 2012

Thanks Ondra! I will try to review it today.

Contributor

sgilda commented Nov 13, 2012

Hi Ondra,

There are 2 new pom.xml files in this commit:

memcached-endpoint/pom.xml
rest-endpoint/pom.xml

However, there is no memcached-endpoint or rest-endpoint quickstart that I can see. Are these files supposed to be here?

Contributor

OndraZizka commented Nov 14, 2012

Could happen that I put it there during rebasing, while they were removed since my original base. I'll check that tomorrow.

Contributor

sgilda commented Nov 28, 2012

@OndraZizka : did you ever get a chance to check into the extra pom.xml files?

Contributor

OndraZizka commented Jan 7, 2013

Rebasing...

Contributor

OndraZizka commented Jan 7, 2013

Rebased, and the two pom.xml's removed:
memcached-endpoint/pom.xml
rest-endpoint/pom.xml

@sgilda sgilda commented on an outdated diff Jan 7, 2013

kitchensink-html5-mobile/pom.xml
@@ -55,6 +55,7 @@
<version.license.plugin>1.9.0</version.license.plugin>
<version.surefire.plugin>2.4.3</version.surefire.plugin>
<version.war.plugin>2.2</version.war.plugin>
+ <version.org.jboss.as.plugins.maven.plugin>7.2.Final</version.org.jboss.as.plugins.maven.plugin>
@sgilda

sgilda Jan 7, 2013

Contributor

This quickstart originates here: https://github.com/aerogear/as-quickstarts/tree/master/kitchensink-html5-mobile; So this fix needs to be made in that repository.

@OndraZizka : do you want to enter a JIRA for this?

Contributor

sgilda commented Jan 7, 2013

The helloworld-html5 and kitchensink-html5-mobile quickstart originate here: https://github.com/aerogear/as-quickstarts/ so those fixes need to be made in that repository.

Actually, there are quite a few properties defined in the kitchensink-html5-mobile here that aren't in the Aerogear version.

@OndraZizka : Do you want to enter a JIRA for this or can you make the same changes there?

Contributor

OndraZizka commented Jan 7, 2013

Reverted kitchensing changes and squashed.
Not sure about jira, when it's almost done? 🎱

Contributor

sgilda commented Jan 7, 2013

@OndraZizka : I'm not clear what you mean by the comment "Not sure about jira, when it's almost done? 🎱 ". Does the kitchensink need that property defined?

Contributor

sgilda commented Jan 7, 2013

@pmuir: do you have any other comments? If not and you're OK with this, I can merge.

Contributor

OndraZizka commented Jan 7, 2013

🎱 is github's icon shortcut which got into comment by autocomplete...

Fix whitespace, indentation, version props.
Fix html5-mobile's POM.
Fix errai and gwt

Fix errai pom indent
Contributor

sgilda commented Jan 9, 2013

Merged.

@sgilda sgilda closed this Jan 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment