Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[WICKET-4785] [AS7-4554] AS 7 + Wicket: ClassNotFoundException: org.jbos... #354

Closed
wants to merge 4 commits into from

3 participants

@OndraZizka

...s.msc.service.ServiceName on deserialization

@sgilda
Owner

Hi Ondra,
I assume this is a fix for some bug? I have a couple of questions:

How do I test this to make sure the fix solves the problem? In other words, how would I get it to break in the current version?

Would you mind squashing the commits to make it easier to review the changes?

Thanks,
Sande

@OndraZizka

Hi Sande, yes it's a bug fix. To try, start AS and deploy the quickstart; then fiddle with the app for a while, adding and deleting some items. Then press the back button. In this scenario, you should get CNFEx coming from deserialization, see the jiras.

@OndraZizka

I can squash, but:
1) is for EAR QS
2) is for WAR QS (different one)
3) is upgrading Wicket framework version - unrelated
4) is unrelated change in pom, clearing some garbage which doesn't belong there

So I suggest to squash 1 + 2 and 3 + 4, wdyt?

@sgilda
Owner

Sorry. I didn't realize it affected multiple quickstarts! Sorry about that. Leave it as is.

Also, thanks for the explanation!

@sgilda
Owner

I tested the wicket-ear and wicket-war quickstarts with this change and they work fine.

Pete, this looks good to me. Do you need to review these changes? There are no code changes, only dependencies.

@pmuir
Owner

Looks good.

@sgilda
Owner

Merged.

@sgilda sgilda closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 11, 2012
  1. @OndraZizka

    [WICKET-4785] [AS7-4554] AS 7 + Wicket: ClassNotFoundException: org.j…

    OndraZizka authored
    …boss.msc.service.ServiceName on deserialization
  2. @OndraZizka

    [WICKET-4785] [AS7-4554] AS 7 + Wicket: ClassNotFoundException: org.j…

    OndraZizka authored
    …boss.msc.service.ServiceName on deserialization
  3. @OndraZizka

    Wicket 155 -> 158

    OndraZizka authored
  4. @OndraZizka
This page is out of date. Refresh to see the latest.
View
1  .gitignore
@@ -30,3 +30,4 @@ bin
*.log
.clover
*.swp
+!/wicket-war/src/main/resources/META-INF/MANIFEST.MF
View
2  wicket-ear/pom.xml
@@ -55,7 +55,7 @@
<!-- <version.org.jboss.spec.jboss.javaee.6.0>3.0.0.Final-redhat-1</version.org.jboss.spec.jboss.javaee.6.0> -->
<!-- Other dependency versions -->
- <version.org.apache.wicket>1.5.5</version.org.apache.wicket>
+ <version.org.apache.wicket>1.5.8</version.org.apache.wicket>
<version.net.ftlines.wicket-cdi>1.2</version.net.ftlines.wicket-cdi>
<!-- other plugin versions -->
View
1  wicket-ear/war/src/main/resources/META-INF/MANIFEST.MF
@@ -0,0 +1 @@
+Dependencies: org.jboss.msc
View
17 wicket-war/pom.xml
@@ -50,7 +50,7 @@
<!-- <version.org.jboss.spec.jboss.javaee.6.0>3.0.0.Final-redhat-1</version.org.jboss.spec.jboss.javaee.6.0> -->
<!-- Other dependency versions -->
- <version.org.apache.wicket>1.5.5</version.org.apache.wicket>
+ <version.org.apache.wicket>1.5.8</version.org.apache.wicket>
<version.net.ftlines.wicket-cdi>1.2</version.net.ftlines.wicket-cdi>
<!-- other plugin versions -->
@@ -94,21 +94,6 @@
<version>${version.net.ftlines.wicket-cdi}</version>
</dependency>
- <!-- EJB JAR module. -->
- <dependency>
- <groupId>org.jboss.as.quickstarts</groupId>
- <artifactId>jboss-as-wicket-ear-ejb</artifactId>
- <version>${project.version}</version>
- <type>ejb</type>
- </dependency>
-
- <!-- WAR module. -->
- <dependency>
- <groupId>org.jboss.as.quickstarts</groupId>
- <artifactId>jboss-as-wicket-ear-war</artifactId>
- <version>${project.version}</version>
- <type>war</type>
- </dependency>
</dependencies>
</dependencyManagement>
View
1  wicket-war/src/main/resources/META-INF/MANIFEST.MF
@@ -0,0 +1 @@
+Dependencies: org.jboss.msc
Something went wrong with that request. Please try again.