Wsba participant completion simple #38

npfr · 2012-01-05T11:51:28Z

This quickstart is one that I've been planning to do for XTS. It's not in the list of AS71 quickstarts, but I'm happy for you to take it if you want it.

It uses technology that will ship and be supported in EAP 6.0.

pmuir · 2012-01-05T13:15:54Z

wsba-participant-completion-simple/pom.xml

+                    <artifactId>jboss-logging-spi</artifactId>
+                </exclusion>
+            </exclusions>
+        </dependency>


Don't we need the JBoss Repository defined to get these artifacts?

pmuir · 2012-01-05T13:18:54Z

I'm happy to include this, pending Sande's usability review of course. If you could collapse it down into one commit before we merge that would be good!

npfr · 2012-01-06T09:04:03Z

FYI,

The commit list is currently looking a bit strange. I managed to break it whilst attempting a squash. I'm currently trying to fix it.

This shouldn't prevent Sande from doing a usability review.

Paul.

npfr · 2012-01-06T11:04:22Z

OK, I think I've successfully squashed to one commit and also addressed your other comments.

sgilda · 2012-01-06T20:05:12Z

Hi Paul,
I'm a stupid user. I'm following the instructions in the README (which is excellent, btw), but I must be missing something. My understanding is that all I need to do is start the server and then run this:
mvn clean test -Parq-jbossas-remote.
When I do that, I get a BUILD FAILURE:
Tests in error:
org.jboss.as.quickstarts.wsba.participantcompletion.simple.ClientTest: Could not deploy to container

I am running jboss-as-7.1.0.Final-SNAPSHOT.
Did I miss a step or misunderstand what I need to do?

Thanks,
Sande

npfr · 2012-01-07T11:33:53Z

Hi Sande,

The problem was that it was still configured to use JBossAS-7.1.0.Beta1. I've upgraded to CR1b and also made updates to the Arquillian version too. This should fix it. I think there are other quickstarts that have the same problem. I'll take a look and raise a pull req if appropriate.

I'll squash into a single commit, once it's been approved.

Paul.

npfr · 2012-01-07T11:45:54Z

Looks like the problem occurs prior to 7.1.0.Beta1b and is probably caused by the remoting incompatibility that necessitated the 7.1.0.Beta1b release.

I've checked master and all Arquillian versions are using AS 7.1.0.Beta1b or above:

[paul@wiggum quickstart]$ grep -r -A 1 "<artifactId>jboss-as-arquillian-container-remote</artifactId>" .
./html5-mobile/pom.xml:               <artifactId>jboss-as-arquillian-container-remote</artifactId>
./html5-mobile/pom.xml-               <version>7.1.0.Beta1b</version>
--
./kitchensink/pom.xml:               <artifactId>jboss-as-arquillian-container-remote</artifactId>
./kitchensink/pom.xml-               <version>7.1.0.Beta1b</version>
--
./kitchensink-ear/jboss-as-kitchensink-ear-ejb/pom.xml:               <artifactId>jboss-as-arquillian-container-remote</artifactId>
./kitchensink-ear/jboss-as-kitchensink-ear-ejb/pom.xml-               <version>7.1.0.Beta1b</version>
--
./kitchensink-jsp/pom.xml:               <artifactId>jboss-as-arquillian-container-remote</artifactId>
./kitchensink-jsp/pom.xml-               <version>7.1.0.Beta1b</version>

To be sure I ran the Arquillian tests on kitchensink against 7.1.0.CR1b and they pass.

I assume you have plans to control these version numbers centrally, so I won't bother issuing a pull request to update them.

sgilda · 2012-01-07T16:46:27Z

Thanks Paul.

Pete, do we control them centrally? Or do we expect them to match up for
the scripts to find them?

On 01/07/2012 06:45 AM, Paul Robinson wrote:

Looks like the problem occurs prior to 7.1.0.Beta1b and is probably caused by the remoting incompatibility that necessitated the 7.1.0.Beta1b release.

I've checked master and all Arquillian versions are using AS 7.1.0.Beta1b or above:
 [paul@wiggum quickstart]$ grep -r -A 1 "<artifactId>jboss-as-arquillian-container-remote</artifactId>" .
 ./html5-mobile/pom.xml:<artifactId>jboss-as-arquillian-container-remote</artifactId>
 ./html5-mobile/pom.xml-<version>7.1.0.Beta1b</version>
 --
 ./kitchensink/pom.xml:<artifactId>jboss-as-arquillian-container-remote</artifactId>
 ./kitchensink/pom.xml-<version>7.1.0.Beta1b</version>
 --
 ./kitchensink-ear/jboss-as-kitchensink-ear-ejb/pom.xml:<artifactId>jboss-as-arquillian-container-remote</artifactId>
 ./kitchensink-ear/jboss-as-kitchensink-ear-ejb/pom.xml-<version>7.1.0.Beta1b</version>
 --
 ./kitchensink-jsp/pom.xml:<artifactId>jboss-as-arquillian-container-remote</artifactId>
 ./kitchensink-jsp/pom.xml-<version>7.1.0.Beta1b</version>
To be sure I ran the Arquillian tests on kitchensink against 7.1.0.CR1b and they pass.

I assume you have plans to control these version numbers centrally, so I won't bother issuing a pull request to update them.

Reply to this email directly or view it on GitHub:
https://github.com/jbossas/quickstart/pull/38#issuecomment-3395331

npfr · 2012-01-11T09:28:06Z

I've applied the AS7 code style.

npfr · 2012-01-11T11:43:17Z

I've also moved the index entry for this quickstart into README.md

npfr · 2012-01-11T11:45:45Z

Squashed

pmuir · 2012-01-11T14:01:29Z

Sande, are we done on this one? Can we merge it?

sgilda · 2012-01-11T15:43:16Z

I now see BUILD SUCCESS with this result: Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
However, I'm not clear what I'm supposed to see for the result.

in the server console I see that it starts the deployment, adds a service, registers it, then there are a lot of "Creating Service" messages.
Then I see this exception in the log:
Method invocation failed with exception: null: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [:1.6.0_25]
{removed stacktrace}
Caused by: org.jboss.as.quickstarts.wsba.participantcompletion.simple.AlreadyInSetException:
item '1' is already in the set.
Then I see more "Creating Service" messages, followed by "remove: jboss.ws:context=wsba,endpoint=SetServiceBA", then "Stopped deployment wsba.war" , then Undeployed "wsba.war"

The README says it assumes you have an understanding of WS-BusinessActivity. I'm a stupid user, so I don't. My question is, what am I looking for when I run this example to know that this is running correctly? Should I see anything in shell prompt where I run "mvn clean test -Parq-jbossas-remote"? Do I look in the server log? If so, what should I expect to see?

There is a minor typo 'tht' in the README: 'It is also assumed tht you'.

npfr · 2012-01-11T16:17:32Z

I added logging to the quickstart, but it is difficult to differentiate from all the other logging produced by JBossAS, XTS, JBossWS, etc. For that reason, I didn't mention it in the readme.

However, I agree it would be better to provide some indication of what is going on. I'll have a think about the best way to do this. I'll also take a look at some of the other quickstarts as I'm sure they will have hit the same issue.

sgilda · 2012-01-11T17:29:16Z

Thanks. I appreciate it!

npfr · 2012-01-17T11:48:13Z

Added the expected output and improved the server startup instructions. @sgilda, can you re-review please?

npfr · 2012-01-18T14:54:18Z

@sgilda I've fixed the inconsistencies.

sgilda · 2012-01-18T16:40:05Z

Thanks. I'll take a look at it now.

sgilda · 2012-01-18T20:14:09Z

This looks great! I will merge it in soon.

sgilda · 2012-01-19T21:46:31Z

Hi Paul,
While copying a description for the quickstart page, I noticed a small typo "Bushiness" in the README file:
This example demonstrates the deployment of a WS-BA (WS Bushiness Activity) enabled JAX-WS Web service bundled in a war archive for deployment to JBoss AS 7.
Thought you might want to change it on your end. :-)
Sande

npfr · 2012-01-19T21:48:01Z

Cheers, I'll get that sorted tomorrow.

On 19 Jan 2012, at 21:46, sgilda reply@reply.github.com wrote:

Hi Paul,
While copying a description for the quickstart page, I noticed a small typo "Bushiness" in the README file:
This example demonstrates the deployment of a WS-BA (WS Bushiness Activity) enabled JAX-WS Web service bundled in a war archive for deployment to JBoss AS 7.
Thought you might want to change it on your end. :-)
Sande

Reply to this email directly or view it on GitHub:
https://github.com/jbossas/quickstart/pull/38#issuecomment-3574931

npfr · 2012-01-20T09:48:13Z

Fixed the 'bushiness' typo.

npfr · 2012-01-20T10:36:18Z

I think I have the version numbers aligned with HEAD.
I changed 'arquillian-junit-container' and 'arquillian-protocol-servlet'.

npfr · 2012-01-20T10:39:34Z

Squashed

sgilda · 2012-01-20T17:41:41Z

Looking at this next...

sgilda · 2012-01-24T13:14:51Z

Hi Paul,
Sorry for the delay in getting to this.
I just looked at your POM and noticed some of the versions are off a bit. For example:
jboss-as-arquillian-* artifactId patterns should be 7.1.0.CR1b
org.jboss.arquillian.* groupIds pattern should be 1.0.0.CR7.
jboss-as-maven-plugin artifactId should be 7.1.0.CR1
This information was probably changed after you started this quickstart. We need them all to be consistent so we can use scripts to update them when they are moved to EAP and also to avoid runtime errors.
I created this page to use for a reference: https://docs.jboss.org/author/display/AS71/Maven+POM+Versions+Checklist
Sorry to make you go through all this again, but do you mind updating the pom.xml file again?
Thanks, Sande

sgilda · 2012-02-01T15:24:21Z

I made the changes and issued pull 81: https://github.com/jbossas/quickstart/pull/81.
Pete, is it OK to close this one?

pmuir · 2012-02-01T16:27:27Z

81 is closed. Closing this one too.

JBEAP-10717: Fix typos and rendering issues in ha-singleton-deploymen…

pmuir reviewed Jan 5, 2012
View reviewed changes

ghost assigned sgilda Jan 11, 2012

Initial version of wsba-participant-completion-simple quickstart

f215252

pmuir closed this Feb 1, 2012

ctomc added a commit that referenced this pull request Jul 3, 2017

Merge pull request #38 from sgilda/JBEAP-10717

163901e

JBEAP-10717: Fix typos and rendering issues in ha-singleton-deploymen…

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wsba participant completion simple #38

Wsba participant completion simple #38

npfr commented Jan 5, 2012

pmuir Jan 5, 2012

pmuir commented Jan 5, 2012

npfr commented Jan 6, 2012

npfr commented Jan 6, 2012

sgilda commented Jan 6, 2012

npfr commented Jan 7, 2012

npfr commented Jan 7, 2012

sgilda commented Jan 7, 2012

npfr commented Jan 11, 2012

npfr commented Jan 11, 2012

npfr commented Jan 11, 2012

pmuir commented Jan 11, 2012

sgilda commented Jan 11, 2012

npfr commented Jan 11, 2012

sgilda commented Jan 11, 2012

npfr commented Jan 17, 2012

npfr commented Jan 18, 2012

sgilda commented Jan 18, 2012

sgilda commented Jan 18, 2012

sgilda commented Jan 19, 2012

npfr commented Jan 19, 2012

npfr commented Jan 20, 2012

npfr commented Jan 20, 2012

npfr commented Jan 20, 2012

sgilda commented Jan 20, 2012

sgilda commented Jan 24, 2012

sgilda commented Feb 1, 2012

pmuir commented Feb 1, 2012

Wsba participant completion simple #38

Wsba participant completion simple #38

Conversation

npfr commented Jan 5, 2012

pmuir Jan 5, 2012

Choose a reason for hiding this comment

pmuir commented Jan 5, 2012

npfr commented Jan 6, 2012

npfr commented Jan 6, 2012

sgilda commented Jan 6, 2012

npfr commented Jan 7, 2012

npfr commented Jan 7, 2012

sgilda commented Jan 7, 2012

npfr commented Jan 11, 2012

npfr commented Jan 11, 2012

npfr commented Jan 11, 2012

pmuir commented Jan 11, 2012

sgilda commented Jan 11, 2012

npfr commented Jan 11, 2012

sgilda commented Jan 11, 2012

npfr commented Jan 17, 2012

npfr commented Jan 18, 2012

sgilda commented Jan 18, 2012

sgilda commented Jan 18, 2012

sgilda commented Jan 19, 2012

npfr commented Jan 19, 2012

npfr commented Jan 20, 2012

npfr commented Jan 20, 2012

npfr commented Jan 20, 2012

sgilda commented Jan 20, 2012

sgilda commented Jan 24, 2012

sgilda commented Feb 1, 2012

pmuir commented Feb 1, 2012