Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Developer 827 #406

Merged
merged 2 commits into from

4 participants

Pete Muir jboss-developer Wes Bos Paul Robinson
Pete Muir
Owner

@wesbos please review, as I suspect I broke something by adding the html tag to the page directly like this.

jboss-developer
Collaborator

Triggering build using a merge of 0a6c566 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/

jboss-developer
Collaborator

Build 422 is now running using a merge of 0a6c566 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/422

jboss-developer
Collaborator

Related issue: DEVELOPER-827

_layouts/base.html.slim
((3 lines not shown))
/[if IE 8]
| <html class="ie8 lt-ie9">
/[if IE 9]
| <html class="ie9">
-/ <!--[if (gte IE 9)|!(IE)]<!--> <html> <!--<![endif]-->
+/ [if (gte IE 9)|!(IE)]<!--> <html> <!--<![endif]-->
+html lang="en"
Wes Bos
wesbos added a note

Is there a reason you added it like this? Do you need to add the lang attribute? This will cause double HTML tags in all browsers

Pete Muir Owner
pmuir added a note

Yes, I need to add the lang attribute. What is the right way to do that?

Wes Bos
wesbos added a note

Yeah you'll need to put them in each HTML tag, like this:

pmuir#2

and then you also took out the comment on line 6, that is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Pete Muir
Owner

@wesbos unfortunately that doesn't seem to do anything - http://screencast.com/t/CRpVoY62C4lx

Wes Bos

@pmuir it added the html lang attr, isn't that what you wanted?

Pete Muir
Owner
Wes Bos

Ah I see, the last HTML tag doesn't get it added. Let me have a look

Wes Bos

Okay take a look at the PR I sent you, a little tricky with slim comments, to but it now ouputs the lang on all three html tags.

jboss-developer
Collaborator

Triggering build using a merge of 9eced56 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/

jboss-developer
Collaborator

Build 453 is now running using a merge of 9eced56 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/453

Pete Muir
Owner

Ok, this now looks good.

Paul Robinson

@wesbos Are you now happy with this too?

Wes Bos

Yep

Paul Robinson paulrobinson merged commit 9779a06 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 23, 2014
  1. Pete Muir

    DEVELOPER-827 add lang tag

    pmuir authored
  2. Wes Bos Pete Muir
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 4 deletions.
  1. +4 −4 _layouts/base.html.slim
8 _layouts/base.html.slim
View
@@ -1,9 +1,9 @@
-doctype html
+doctype html
/[if IE 8]
- | <html class="ie8 lt-ie9">
+ | <html class="ie8 lt-ie9" lang="en">
/[if IE 9]
- | <html class="ie9">
-/ <!--[if (gte IE 9)|!(IE)]<!--> <html> <!--<![endif]-->
+ | <html class="ie9" lang="en">
+/! [if (gte IE 9)|!(IE)]<!--> <html lang="en"> <!--<![endif]
head
meta charset='utf-8'
Something went wrong with that request. Please try again.