Developer 827 #406

Merged
merged 2 commits into from Jul 24, 2014

4 participants

@pmuir
JBoss Developer member

@wesbos please review, as I suspect I broke something by adding the html tag to the page directly like this.

@wesbos wesbos and 1 other commented on an outdated diff Jul 21, 2014
_layouts/base.html.slim
/[if IE 8]
| <html class="ie8 lt-ie9">
/[if IE 9]
| <html class="ie9">
-/ <!--[if (gte IE 9)|!(IE)]<!--> <html> <!--<![endif]-->
+/ [if (gte IE 9)|!(IE)]<!--> <html> <!--<![endif]-->
+html lang="en"
@wesbos
wesbos added a line comment Jul 21, 2014

Is there a reason you added it like this? Do you need to add the lang attribute? This will cause double HTML tags in all browsers

@pmuir
JBoss Developer member
pmuir added a line comment Jul 22, 2014

Yes, I need to add the lang attribute. What is the right way to do that?

@wesbos
wesbos added a line comment Jul 22, 2014

Yeah you'll need to put them in each HTML tag, like this:

pmuir#2

and then you also took out the comment on line 6, that is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@pmuir
JBoss Developer member

@wesbos unfortunately that doesn't seem to do anything - http://screencast.com/t/CRpVoY62C4lx

@wesbos

@pmuir it added the html lang attr, isn't that what you wanted?

@pmuir
JBoss Developer member
@wesbos

Ah I see, the last HTML tag doesn't get it added. Let me have a look

@wesbos

Okay take a look at the PR I sent you, a little tricky with slim comments, to but it now ouputs the lang on all three html tags.

@pmuir
JBoss Developer member

Ok, this now looks good.

@paulrobinson

@wesbos Are you now happy with this too?

@wesbos

Yep

@paulrobinson paulrobinson merged commit 9779a06 into jboss-developer:master Jul 24, 2014

1 check passed

Details jboss-developer-ci JBoss Developer CI build status: success
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment