Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBPM-7477 - New docker image for full distribution #39

Merged
merged 1 commit into from Jul 31, 2018
Merged

JBPM-7477 - New docker image for full distribution #39

merged 1 commit into from Jul 31, 2018

Conversation

cristianonicolai
Copy link
Contributor

@cristianonicolai cristianonicolai commented Jul 30, 2018 •
edited

@cristianonicolai
Copy link
Contributor Author

cristianonicolai commented Jul 30, 2018 •
edited

@mbiarnes @mswiderski @bsremac please take a look.

New image based on jBPM single zip distribution with tweak and examples to connect with different databases.

mswiderski
mswiderski reviewed Jul 30, 2018
View reviewed changes
Copy link

@mswiderski mswiderski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristianonicolai looks really cool. What would be the procedure to get this running locally to test it?

@cristianonicolai
Copy link
Contributor Author

@mswiderski just use the ./build.sh script to build the image locally and then you can follow/check the instructions I added to the README file as this is how people will try it out once it is available on Docker Hub.

@mbiarnes
Copy link
Contributor

@cristianonicolai looks good - I will close my PR that upgrades the existing files to 7.9.0.Final - so we prevent merge conflicts
I want Roger to see this :)

mbiarnes
mbiarnes approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@mbiarnes mbiarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good. Should be also used for upgrading to 7.9.0.Final

@mbiarnes mbiarnes mentioned this pull request Jul 30, 2018
Closed
mswiderski
mswiderski approved these changes Jul 31, 2018
View reviewed changes
Copy link

@mswiderski mswiderski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tested this and it works perfectly. Great job

@mbiarnes mbiarnes merged commit 272ac8f into jboss-dockerfiles:master Jul 31, 2018
@cristianonicolai cristianonicolai deleted the JBPM-7477 branch July 31, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswiderski mswiderski mswiderski approved these changes

@mbiarnes mbiarnes mbiarnes approved these changes

@romartin romartin Awaiting requested review from romartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cristianonicolai @mbiarnes @mswiderski