Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XTS and RTS images #1

Merged
merged 3 commits into from Jun 3, 2015

Conversation

Projects
None yet
2 participants
@gytis
Copy link
Contributor

commented May 6, 2015

No description provided.

@gytis

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2015

Could somebody take a look at this, please?

@@ -0,0 +1,9 @@
# Use latest jboss/wildfly image as the base
FROM jboss/wildfly

This comment has been minimized.

Copy link
@goldmann

goldmann May 21, 2015

Member

Please add a tag here: :8.2.0.Final for example.

FROM jboss/wildfly

# Make standalone-rts.xml configuration default
RUN cp /opt/jboss/wildfly/docs/examples/configs/standalone-rts.xml /opt/jboss/wildfly/standalone/configuration/standalone.xml

This comment has been minimized.

Copy link
@goldmann

goldmann May 21, 2015

Member

You can use $JBOSS_HOME env variable everywhere.


# Set the default command to run on boot
# This will boot WildFly in the standalone rts mode and bind to all interfaces
CMD ["/opt/jboss/wildfly/bin/standalone.sh", "-b", "0.0.0.0"]

This comment has been minimized.

Copy link
@goldmann

goldmann May 21, 2015

Member

You do not need to specify the CMD again, it'll be reused from the jboss/wildfly image.

@gytis

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2015

@goldmann, I've updated commits

@goldmann

This comment has been minimized.

Copy link
Member

commented May 22, 2015

It would be probably good to follow the convention to name the readme file as README.md. I'm always looking for files in upper case when I look for readme's and licenses.

Otherwise looks good!

@gytis

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2015

@goldmann, sorry for the late rely, I was away.
Anyway, I have now updated the readme file names. (I didn't know that it's the convention to have them capitalised).

goldmann added a commit that referenced this pull request Jun 3, 2015

@goldmann goldmann merged commit eb1e5cb into jboss-dockerfiles:master Jun 3, 2015

@goldmann

This comment has been minimized.

Copy link
Member

commented Jun 3, 2015

Thanks!

@gytis gytis deleted the gytis:master-xts-and-rts-images branch Jul 31, 2015

ochaloup added a commit to ochaloup/narayana-jboss-dockerfiles that referenced this pull request Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.