Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODULES-372] provide our own "java.se" module on JDK 9+ #233

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@Ladicek
Copy link
Contributor

commented Jan 29, 2019

The java.se module in JDK 9+ isn't "available" by default. However,
it's merely an aggregator of other modules that are "available".
This commit provides our own java.se module even on JDK 9+, instead
of delegating to JPMS. The new java.se module aggregates the same
modules as the java.se module in the JDK, the only difference is
that it's constructed on the JBoss Modules level and hence doesn't
require users to start JVM with --add-modules java.se.

@Ladicek

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

Also if we could get a release with this (1.9? 1.10?), that would be great for us (Thorntail).

[MODULES-372] provide our own "java.se" module on JDK 9+
The `java.se` module in JDK 9+ isn't "available" by default. However,
it's merely an aggregator of other modules that _are_ "available".
This commit provides our own `java.se` module even on JDK 9+, instead
of delegating to JPMS. The new `java.se` module aggregates the same
modules as the `java.se` module in the JDK, the only difference is
that it's constructed on the JBoss Modules level and hence doesn't
require users to start JVM with `--add-modules java.se`.

@Ladicek Ladicek force-pushed the Ladicek:emulated-java-se-module branch from 078ddaf to 58ec1e5 Jan 30, 2019

@Ladicek

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

Rebased.

@gastaldi
Copy link
Contributor

left a comment

LGTM and we could use a release with this patch in Forge too

@dmlloyd dmlloyd merged commit b925d92 into jboss-modules:1.x Feb 4, 2019

3 checks passed

Linux (Pull Request) - merge TeamCity build finished
Details
Linux JDK10 (Pull Request) - merge TeamCity build finished
Details
Windows (Pull Request) - merge TeamCity build finished
Details

@Ladicek Ladicek deleted the Ladicek:emulated-java-se-module branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.