Permalink
Commits on Jan 26, 2012
  1. Prep 1.0.2.GA

    dmlloyd committed Jan 26, 2012
Commits on Jan 25, 2012
  1. ServiceRegistrationImpl must not perform operations on the internal s…

    …ervice inside its own lock.
    
    Or else we can get an assertion error such as this one:
    16:59:01,616 WARN  [org.jboss.msc.service] (main) MSC00007: An internal service error has occurred while processing an operation on service serviceTwo: java.lang.AssertionError
    	at org.jboss.msc.service.ServiceRegistrationImpl.dependentStarted(ServiceRegistrationImpl.java:205)
    	at org.jboss.msc.service.ServiceControllerImpl$DependentStartedTask.run(ServiceControllerImpl.java:1666)
    	at org.jboss.msc.service.ServiceControllerImpl.doExecute(ServiceControllerImpl.java:685)
    	at org.jboss.msc.service.ServiceControllerImpl.invokeListener(ServiceControllerImpl.java:1490)
    	at org.jboss.msc.service.ServiceControllerImpl.access$2700(ServiceControllerImpl.java:49)
    	at org.jboss.msc.service.ServiceControllerImpl$ListenerTask.run(ServiceControllerImpl.java:1980)
    	at org.jboss.msc.service.ServiceControllerImpl.doExecute(ServiceControllerImpl.java:685)
    	at org.jboss.msc.service.ServiceControllerImpl.invokeListener(ServiceControllerImpl.java:1490)
    	at org.jboss.msc.service.ServiceControllerImpl.access$2700(ServiceControllerImpl.java:49)
    	at org.jboss.msc.service.ServiceControllerImpl$ListenerTask.run(ServiceControllerImpl.java:1980)
    	at org.jboss.msc.service.ServiceControllerImpl.doExecute(ServiceControllerImpl.java:685)
    	at org.jboss.msc.service.ServiceControllerImpl.immediateDependencyUp(ServiceControllerImpl.java:1009)
    	at org.jboss.msc.service.ServiceControllerImpl$DependencyStartedTask.run(ServiceControllerImpl.java:2002)
    	at org.jboss.msc.service.ServiceControllerImpl.doExecute(ServiceControllerImpl.java:685)
    	at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1793)
    	at org.jboss.msc.service.ServiceControllerImpl.doExecute(ServiceControllerImpl.java:685)
    	at org.jboss.msc.service.ServiceControllerImpl$DependentStartedTask.run(ServiceControllerImpl.java:1679)
    	at org.jboss.msc.service.ServiceControllerImpl.doExecute(ServiceControllerImpl.java:685)
    	at org.jboss.msc.service.ServiceControllerImpl$DemandParentsTask.run(ServiceControllerImpl.java:1610)
    	at org.jboss.msc.service.ServiceControllerImpl.doExecute(ServiceControllerImpl.java:685)
    	at org.jboss.msc.service.ServiceControllerImpl.addDemands(ServiceControllerImpl.java:1142)
    	at org.jboss.msc.service.ServiceControllerImpl.addDemand(ServiceControllerImpl.java:1121)
    	at org.jboss.msc.service.ServiceRegistrationImpl.addDemand(ServiceRegistrationImpl.java:220)
    	at org.jboss.msc.service.ServiceControllerImpl.doDemandParents(ServiceControllerImpl.java:1105)
    	at org.jboss.msc.service.ServiceControllerImpl.access$500(ServiceControllerImpl.java:49)
    	at org.jboss.msc.service.ServiceControllerImpl$DemandParentsTask.run(ServiceControllerImpl.java:1602)
    	at org.jboss.msc.service.ServiceControllerImpl.doExecute(ServiceControllerImpl.java:685)
    	at org.jboss.msc.service.ServiceControllerImpl.commitInstallation(ServiceControllerImpl.java:284)
    	at org.jboss.msc.service.ServiceContainerImpl.install(ServiceContainerImpl.java:563)
    	at org.jboss.msc.service.ServiceBuilderImpl.install(ServiceBuilderImpl.java:307)
    fl4via committed with dmlloyd Jan 25, 2012
  2. The children services mode should not be changed inside the parent's …

    …lock.
    
    Or else we can get an assertion error:
    15:28:29,335 WARN  [org.jboss.msc.service] (main) MSC00007: An internal service error has occurred while processing an operation on service third.service: java.lang.AssertionError
    	at org.jboss.msc.service.ServiceControllerImpl.removeDemand(ServiceControllerImpl.java:1145)
    	at org.jboss.msc.service.ServiceControllerImpl.doUndemandParents(ServiceControllerImpl.java:1116)
    	at org.jboss.msc.service.ServiceControllerImpl.access$800(ServiceControllerImpl.java:49)
    	at org.jboss.msc.service.ServiceControllerImpl$UndemandParentsTask.run(ServiceControllerImpl.java:1620)
    	at org.jboss.msc.service.ServiceControllerImpl.doExecute(ServiceControllerImpl.java:684)
    	at org.jboss.msc.service.ServiceControllerImpl.invokeListener(ServiceControllerImpl.java:1489)
    	at org.jboss.msc.service.ServiceControllerImpl.access$2600(ServiceControllerImpl.java:49)
    	at org.jboss.msc.service.ServiceControllerImpl$ListenerTask.run(ServiceControllerImpl.java:1964)
    	at org.jboss.msc.service.ServiceControllerImpl.doExecute(ServiceControllerImpl.java:684)
    	at org.jboss.msc.service.ServiceControllerImpl.internalSetMode(ServiceControllerImpl.java:717)
    	at org.jboss.msc.service.ServiceControllerImpl.setMode(ServiceControllerImpl.java:690)
    	at org.jboss.msc.service.ServiceControllerImpl.transition(ServiceControllerImpl.java:593)
    fl4via committed with dmlloyd Jan 25, 2012
  3. [MSC-111] The methods immediateDependencyUnavailable, immediateDepend…

    …encyAvailable, transitiveDependencyUnavailable, and transitiveDependencyUnavailable should all check if the service is not being removed before notifying listeners and dependents.
    
    Plus, add race condition tests for catching all those scenarios.
    fl4via committed with dmlloyd Jan 24, 2012
  4. [AS7-2639] add to ServiceName.getSimpleName() to the exception messag…

    …e to give a hint to the problem
    bmaxwell committed with dmlloyd Nov 15, 2011
Commits on Aug 27, 2011
  1. Next is 1.0.2.GA-SNAPSHOT

    n1hility committed Aug 27, 2011
Commits on Aug 26, 2011
  1. Release 1.0.1.GA

    n1hility committed Aug 26, 2011
  2. [MSC-108] Set the TCCL correctly and update tests.

    Before calling start()/stop() on the service, the TCCL is set to the service's ClassLoader; before invoking listeners methods, the TCCL is set the the listener's ClassLoader. The same applies to LifecycleContext.execute(Runnable command), whereas the TCCL is set to the command's ClassLoader before invoking command.run().
    Update tests accordingly to check that the TCCL is correctly set.
    fl4via committed Aug 25, 2011
Commits on Jul 7, 2011
  1. [MSC-106] Solve random hanging problem involving NewDependentOfFailin…

    …gServiceTestCase and enable the test.
    fl4via committed Jul 7, 2011
Commits on Jul 6, 2011
  1. [MSC-106] Before calling dependencyFailed, ServiceControllerImpl.newD…

    …ependent() should checking if state is not STARTING to avoid duplicate notification.
    
    Plus, add a race condition test case for this.
    fl4via committed with dmlloyd Jul 5, 2011
  2. Next will be 1.0.1

    dmlloyd committed Jul 6, 2011
Commits on Jul 5, 2011
  1. Prep 1.0.0.GA

    dmlloyd committed Jul 5, 2011
  2. Update dependencies

    dmlloyd committed Jul 5, 2011
Commits on Jun 29, 2011
  1. Add real test logging

    dmlloyd committed Jun 29, 2011
Commits on Jun 22, 2011
  1. Next is 1.0.0.CR3

    dmlloyd committed Jun 22, 2011
  2. Prep 1.0.0.CR2

    dmlloyd committed Jun 22, 2011
Commits on Jun 21, 2011
  1. Next is 1.0.0.CR2

    dmlloyd committed Jun 21, 2011
  2. Prep 1.0.0.CR1

    dmlloyd committed Jun 21, 2011
Commits on Jun 20, 2011
  1. Test for MSC-103

    stuartwdouglas committed Jun 20, 2011
Commits on Jun 15, 2011
  1. [MSC-98] Include cycle information at CircularDependencyException.

    Update DependencyCycleTestCase to check if cycle information is accurate.
    Also, update RemovalDuringcycleDetectionTest due to changes in cycle detection bytecodes.
    fl4via committed Jun 14, 2011
Commits on Jun 14, 2011
  1. [MSC-100] At ServiceControllerImpl.commitInstallation, remove the uns…

    …ynchronized block between the moment dependents are notified of dependency availability and the moment a service status is set from NEW to DOWN.
    
    If a second thread attempts to install a  dependent at the moment this unsynchronized block is executing, the dependent will fail to receive an immediateDependencyAvailable notification. As a result, this dependent will never be able to start.
    
    Create race condition InstallDependentDuringDependencyInstallationTestCase to check the bug is fixed.
    fl4via committed Jun 14, 2011
Commits on May 27, 2011
  1. [MSC-99] Listener inheritance

    dmlloyd committed May 27, 2011
  2. Fix minor generics issue

    dmlloyd committed May 27, 2011
Commits on May 25, 2011
  1. Clear TCCL after user tasks

    dmlloyd committed May 25, 2011
Commits on May 24, 2011
Commits on May 23, 2011
  1. Comment; also, add convenience methods for identifying transitions wh…

    …ich enter or leave rest states
    dmlloyd committed May 23, 2011
Commits on May 20, 2011
Commits on May 19, 2011
  1. Clean up some warnings

    dmlloyd committed May 19, 2011
Commits on May 18, 2011
  1. [MSC-93] Avoid sending an immediateDependencyAvailable notification w…

    …ithout an immediateDependencyUnavailable counterpart.
    
    Such a scenario could happen during a service installation, if the ServiceRegistrationImpl object gets an addDependent call
    before the instance installation is committed, but after the instance was set.
    This behavior could also lead to a missing immediateDependencyUnavailable call if a dependent is added to a service whose
    ongoing installation will be rolled back.
    fl4via committed May 18, 2011
Commits on May 17, 2011
  1. Adjust exception message

    dmlloyd committed May 17, 2011
  2. [MSC-91] Allow removal requests to be cleared whenever the service ha…

    …sn't entered REMOVING substate.
    
    Add two racecondition tests to simulate a scenario whereas the removal request can be successfully cleared, and another scenario where it is too late to revert removal..
    fl4via committed May 17, 2011