Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWITCHYARD-461 "Update module.xml for the apache spring and jms modules to contain a slot to camel core" #231

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 16, 2011

No description provided.

@kcbabo
Copy link
Member

kcbabo commented Sep 19, 2011

The spring module dependency appears to be set to version.camel in the jms module.xml. Is this right?

@kcbabo
Copy link
Member

kcbabo commented Sep 21, 2011

Hey - I was talking to Stuart Douglas and it turns out that the slot functionality is really meant as an override as opposed to a versioning system that all modules should use. So an example would be with JSF, where the primary/latest version of JSF is slotted in main and the older version has a specific slot version. I think we should take the same approach with our modules -- using main in our distribution and if an application requires a different version, they can always add a module with a specific slot name.

Thoughts?

@danbev
Copy link
Contributor Author

danbev commented Sep 21, 2011

Hey Keith,
for the SwitchYard components I think this makes sense and this is what we do today with all of the SwitchYard Components. For thirdparty applications like Camel and Spring I just thought that it might not be uncommon to have several version of them deployed in the same environment. But as you say, this is something that users can manage them selves and perhaps we should not force them in either way.
Should I reject this jira and create on that removes the version slot usage for Camel and Spring modules?

@kcbabo
Copy link
Member

kcbabo commented Sep 27, 2011

Updating this based on our conclusion from the meeting yesterday. The slot definitions with version numbers should be removed.

@kcbabo
Copy link
Member

kcbabo commented Oct 3, 2011

The affected files have all been moved to the release repository, so I have made the same changes over there and pushed to upstream.

jboss-switchyard/release@3a8c19c

~ keith

@kcbabo kcbabo closed this Oct 3, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants