SWITCHYARD-2194 - Work on validation of Camel Route implementation #395

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@bfitzpat
Member

bfitzpat commented Jul 3, 2014

No description provided.

@bfitzpat

This comment has been minimized.

Show comment Hide comment
@bfitzpat

bfitzpat Jul 31, 2014

Member

@rcernich Can you take another look and see if this addresses your comments from before? Thanks for all the great feedback - it helped a ton.

Member

bfitzpat commented Jul 31, 2014

@rcernich Can you take another look and see if this addresses your comments from before? Thanks for all the great feedback - it helped a ton.

@bfitzpat

This comment has been minimized.

Show comment Hide comment
@bfitzpat

bfitzpat Aug 6, 2014

Member

Ok @rcernich I have updated this PR with a negative test. When I import the project into my local workspace (outside the test) I see 10 switchyard markers, which is what I'm expecting. But when I run the test, I'm getting zero. I have run this thing more times than I can count over the last 12 hours and it fails every time. I'm sure it's something stupid. Any suggestions?

Member

bfitzpat commented Aug 6, 2014

Ok @rcernich I have updated this PR with a negative test. When I import the project into my local workspace (outside the test) I see 10 switchyard markers, which is what I'm expecting. But when I run the test, I'm getting zero. I have run this thing more times than I can count over the last 12 hours and it fails every time. I'm sure it's something stupid. Any suggestions?

@rcernich

This comment has been minimized.

Show comment Hide comment
@rcernich

rcernich Aug 6, 2014

Member

You might try nuking the .project, .classpath, .settings and other . files from the project prior to running your build. That's just a guess. Check the output for any stack traces; maybe something is preventing the builder from running.

Member

rcernich commented Aug 6, 2014

You might try nuking the .project, .classpath, .settings and other . files from the project prior to running your build. That's just a guess. Check the output for any stack traces; maybe something is preventing the builder from running.

@bfitzpat

This comment has been minimized.

Show comment Hide comment
@bfitzpat

bfitzpat Aug 6, 2014

Member

Ok I'll give that a shot. Thanks!

Member

bfitzpat commented Aug 6, 2014

Ok I'll give that a shot. Thanks!

@bfitzpat

This comment has been minimized.

Show comment Hide comment
@bfitzpat

bfitzpat Aug 6, 2014

Member

That did the trick. It was the SwitchYard model version in the pom causing the problems. I have that resolved now. Will add a positive test (i.e. a project with all the necessary bits in place and no errors) and then think this is done. Thanks for the help Rob!

Member

bfitzpat commented Aug 6, 2014

That did the trick. It was the SwitchYard model version in the pom causing the problems. I have that resolved now. Will add a positive test (i.e. a project with all the necessary bits in place and no errors) and then think this is done. Thanks for the help Rob!

@bfitzpat

This comment has been minimized.

Show comment Hide comment
@bfitzpat

bfitzpat Aug 7, 2014

Member

Ok. Added positive and negative tests and updated to use the adapter instead of the custom file utility. All seems good with the world. Let me know what you think when you get a chance @rcernich! :)

Member

bfitzpat commented Aug 7, 2014

Ok. Added positive and negative tests and updated to use the adapter instead of the custom file utility. All seems good with the world. Let me know what you think when you get a chance @rcernich! :)

@rcernich

This comment has been minimized.

Show comment Hide comment
@rcernich

rcernich Sep 2, 2014

Member

pushed

Member

rcernich commented Sep 2, 2014

pushed

@rcernich rcernich closed this Sep 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment