Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBTM-2415] Clean documentation dependencies #32

Merged
merged 2 commits into from May 19, 2015
Merged

Conversation

@gytis
Copy link
Member

gytis commented May 18, 2015

No description provided.

@tomjenkinson

This comment has been minimized.

Copy link
Contributor

tomjenkinson commented May 18, 2015

Its not that I disagree with your changes but the pom.xml is hard to review as it looks like you reformatted it? Also, it looks like your build failed: http://albany.eng.hst.ams2.redhat.com/view/Narayana-pulls/job/btny-pulls-documentation/1412/

@tomjenkinson tomjenkinson removed their assignment May 18, 2015
@gytis

This comment has been minimized.

Copy link
Member Author

gytis commented May 18, 2015

Do you mean I should revert indentation changes? Or extract it to separate commit?

How come PR isn't updated with CI results?

@tomjenkinson

This comment has been minimized.

Copy link
Contributor

tomjenkinson commented May 18, 2015

I don't know, you could take a look if you don't mind? its possible that comment_on_pull code wasn't added to this PR job. Copy it from the quickstart one if it isn't there...

@jbosstm-bot

This comment has been minimized.

Copy link

jbosstm-bot commented May 18, 2015

@jbosstm-bot

This comment has been minimized.

@gytis

This comment has been minimized.

Copy link
Member Author

gytis commented May 18, 2015

@tomjenkinson, I've sorted the pull request job. What about the indentations etc? Should I revert them?

@tomjenkinson

This comment has been minimized.

Copy link
Contributor

tomjenkinson commented May 18, 2015

Its OK to not indent them but what I am saying is I can't review the change this time as the whole file changed.

@jbosstm-bot

This comment has been minimized.

Copy link

jbosstm-bot commented May 19, 2015

@jbosstm-bot

This comment has been minimized.

@gytis

This comment has been minimized.

Copy link
Member Author

gytis commented May 19, 2015

@tomjenkinson, I've moved indentations to the separate commit, so that you could see the changes in another one.

@tomjenkinson

This comment has been minimized.

Copy link
Contributor

tomjenkinson commented May 19, 2015

Ah yes, much better - thanks for that Gytis

@tomjenkinson tomjenkinson removed their assignment May 19, 2015
@gytis gytis merged commit 207fc61 into jbosstm:master May 19, 2015
@gytis gytis deleted the gytis:master-JBTM-2415-Clean-documentation-dependencies branch May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.