JBTM-1016 Run bmcheck.sh regularly to spot inconsistencies between byteman scripts and the code #333
Conversation
| <artifactId>rulecheck-maven-plugin</artifactId> | ||
| <version>${version.org.jboss.byteman}</version> | ||
| <executions> | ||
| <execution> |
There was a problem hiding this comment.
Can a default be set for this, so that we don't have to always specify the phase?
There was a problem hiding this comment.
yeah, process-test-classes is the default phase.
|
You should look for more Byteman rules to check. We have them in other places than XTS recovery tests and TXBridge tests. |
| <goal>rulecheck</goal> | ||
| </goals> | ||
| <configuration> | ||
| <includes>**/*.txt</includes> |
There was a problem hiding this comment.
Do all our Byteman rules have the .txt suffix?
There was a problem hiding this comment.
Good point, and my suggestion is that as part of this Jira we ensure they do and it now becomes an error to use any other extension (e.g. .btm).
They may do already.
Amos, please can you advised developers of this (once merged) via the dev forum: https://community.jboss.org/en/jbosstm/dev/?view=discussions
There was a problem hiding this comment.
Alternatively, we allow .txt and .btm.
Ensuring no one adds rule files with other extensions could be difficult.
There was a problem hiding this comment.
That was why I was thinking of standardising on a single extension (i.e I assume btm allows arbitrary extensions). If btm only allows .btm or .txt then I agree check for both. If it could be .anything then I think we should choose one and it is an error (PR review) to allow anything but that after notification via the forum.
Therefore, do we know what extensions are supported?
There was a problem hiding this comment.
all our byteman rules have the .txt suffix
./ArjunaJTA/jta/target/test-classes/fail2pc.txt
./ArjunaJTA/jta/target/test-classes/recovery.txt
./ArjunaCore/arjuna/target/test-classes/objectstore.txt
./ArjunaCore/arjuna/target/test-classes/reaper.txt
./ArjunaCore/arjuna/target/test-classes/recovery.txt
./txbridge/target/test-classes/scripts/txbridge-byteman-rules.txt
./XTS/localjunit/crash-recovery-tests/target/test-classes/scripts/BASubordinateCrashDuringCommitAfterSubordinateExit.txt
./XTS/localjunit/crash-recovery-tests/target/test-classes/scripts/ATHeuristicRecoveryAfterDelayedCommit.txt
./XTS/localjunit/crash-recovery-tests/target/test-classes/scripts/BASubordinateCrashDuringComplete.txt
./XTS/localjunit/crash-recovery-tests/target/test-classes/scripts/BASubordinateCrashDuringCommit.txt
./XTS/localjunit/crash-recovery-tests/target/test-classes/scripts/ATParticipantCrashAndRecover.txt
./XTS/localjunit/crash-recovery-tests/target/test-classes/scripts/ATSubordinateCrashDuringPrepare.txt
./XTS/localjunit/crash-recovery-tests/target/test-classes/scripts/ATCrashDuringCommit.txt
./XTS/localjunit/crash-recovery-tests/target/test-classes/scripts/BACrashDuringCommit.txt
./XTS/localjunit/crash-recovery-tests/target/test-classes/scripts/ATCrashDuringOnePhaseCommit.txt
./XTS/localjunit/crash-recovery-tests/target/test-classes/scripts/BACrashDuringOnePhaseCommit.txt
./XTS/localjunit/crash-recovery-tests/target/test-classes/scripts/ATSubordinateCrashDuringCommit.txt
./ArjunaJTS/integration/target/test-classes/fail2pc.txt
./ArjunaJTS/integration/target/test-classes/leaveorphan.txt
./ArjunaJTS/integration/target/test-classes/leave-subordinate-orphan.txt
./ArjunaJTS/integration/target/test-classes/leaverunningorphan.txt
|
Started testing this pull request: http://172.17.131.2/job/btny-pulls-narayana/603/ |
|
Tests failed: XTS: SOME TESTS failed |
|
XTS/localjunit/WSTX11-interop SEVERE: Failed: com.jboss.transaction.txinterop.interop.ATTest.testAT4_1 |
|
It looks like https://issues.jboss.org/browse/JBTM-1751 |
|
now all our byteman scripts check OK except some warnings with ArjunaCore/arjuna/test/byteman-scripts/reaper.txt |
|
Re-scheduled PR testing... |
| <configuration> | ||
| <includes> | ||
| <include>**/*.txt</include> | ||
| <include>**/*.btm</include> |
There was a problem hiding this comment.
Would it make sense to have the default includes as "/*.txt" and "/*.btm" set in the byteman plugin. These would be overridden if the "includes" element was set as in above. I guess this is one for @adinn. WDYT?
There was a problem hiding this comment.
It looks good to me.
|
Starting tests http://172.17.131.2/job/btny-pulls-narayana-windows2008/113/ |
|
Build Byteman Failed |
|
Started testing this pull request: http://172.17.131.2/job/btny-pulls-narayana/964/ |
|
Started testing this pull request: http://172.17.131.2/job/btny-pulls-narayana-windows2008/186/ |
|
All tests passed - Job complete http://172.17.131.2/job/btny-pulls-narayana-windows2008/186/ |
|
All tests passed - Job complete http://172.17.131.2/job/btny-pulls-narayana/964/ |
No description provided.