Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBTM-2379] Mark TXBridge and XTS dependencies as provided where possible #835

Conversation

Projects
None yet
3 participants
@gytis
Copy link
Member

commented Apr 30, 2015

!MAIN !BLACKTIE !QA_JTA !QA_JTS_JACORB !PERF
Requires WildFly PR: jbosstm/jboss-as#39

@tomjenkinson

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2015

I don't think most of the change is required (at least for XTS/) if you look at https://repository.jboss.org/nexus/content/groups/public/org/jboss/narayana/xts/jbossxts/5.1.0.Final/jbossxts-5.1.0.Final.pom you can see that there are actually only two dependencies that needs suppressing:
org.jboss.spec.javax.servlet
jboss-servlet-api_3.0_spec
and:
org.jboss.ws
jbossws-api
I think if you just mark these as provided you should be OK with your WFLY PR.

In terms of txbridge: https://repository.jboss.org/nexus/content/groups/public/org/jboss/narayana/jbosstxbridge/5.1.0.Final/jbosstxbridge-5.1.0.Final.pom

I think you just need to add narayana-jta as "provided"

txf and compensations are probably OK as I guess you found those requirements while paring back XTS etc.

@gytis

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2015

Ok, I'll add servlet and jbossws for jbossxts instead of modifying all submodules.
As for txbridge I think jta and jbossxts should be marked as provided.

You're right about txf and compensations. They used to rely on transitive dependencies.

@gytis gytis force-pushed the gytis:master-JBTM-2379-xts-and-txbridge-dependencies branch from d8ceb9f to 93be6b2 Apr 30, 2015

@jbosstm-bot

This comment has been minimized.

Copy link

commented May 1, 2015

@jbosstm-bot

This comment has been minimized.

@tomjenkinson

This comment has been minimized.

Copy link
Contributor

commented May 1, 2015

I see what you mean about txbridge.

@tomjenkinson

This comment has been minimized.

Copy link
Contributor

commented May 1, 2015

Looks good to me thanks

@gytis

This comment has been minimized.

Copy link
Member Author

commented May 1, 2015

merged

@gytis gytis closed this May 1, 2015

@gytis gytis deleted the gytis:master-JBTM-2379-xts-and-txbridge-dependencies branch May 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.