Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBTM-2308 Fixes for extra JTS bean types #865

Closed

Conversation

@mmusgrov
Copy link
Contributor

mmusgrov commented Jun 8, 2015

!XTS !QA_JTA !QA_JTS_JACORB !QA_JTS_JDKORB !PERF !BLACKTIE

@jbosstm-bot

This comment has been minimized.

Copy link

jbosstm-bot commented Jun 8, 2015

@jbosstm-bot

This comment has been minimized.

Copy link

jbosstm-bot commented Jun 8, 2015

@jbosstm-bot

This comment has been minimized.

Copy link

jbosstm-bot commented Jun 8, 2015

@jbosstm-bot

This comment has been minimized.

public class RecoveredTransactionWrapper extends RecoveredTransaction implements ActionBeanWrapperInterface {
UidWrapper wrapper;
ActionBean action;
boolean activated;

This comment has been minimized.

Copy link
@gytis

gytis Jun 8, 2015

Member

Shouldn't these be private? (Same for the other wrapper class)

This comment has been minimized.

Copy link
@mmusgrov

mmusgrov Jun 8, 2015

Author Contributor

These classes are instantiated by reflection:

{code}
Class cl = (Class) Class.forName(w.getClassName());
Constructor constructor = cl.getConstructor(ActionBean.class, UidWrapper.class);
ra = constructor.newInstance(this, w);
{code}

so if I were to mark the constructor as private it produce IllegalAccessException exceptions

This comment has been minimized.

Copy link
@gytis

gytis Jun 8, 2015

Member

I mean class attributes, not constructor.

This comment has been minimized.

Copy link
@mmusgrov

mmusgrov Jun 8, 2015

Author Contributor

OK I'll go back and update their access control (and fix the tab at the same time)


public class RecoveredTransactionWrapper extends RecoveredTransaction implements ActionBeanWrapperInterface {
UidWrapper wrapper;
ActionBean action;

This comment has been minimized.

Copy link
@gytis

gytis Jun 8, 2015

Member

wrapper and action do not seem to be used. (Same for the other wrapper class)

This comment has been minimized.

Copy link
@mmusgrov

mmusgrov Jun 8, 2015

Author Contributor

see my previous comment, they're instantiated by reflection.

@gytis

This comment has been minimized.

Copy link
Member

gytis commented Jun 8, 2015

Seems that tab is used for indentation in JTSOSBTestBase rather than spaces.

@mmusgrov

This comment has been minimized.

Copy link
Contributor Author

mmusgrov commented Jun 8, 2015

We agreed that style should follow whatever format was already in effect. As I recall the file you refer to already used a mix of spaces and tabs.

@mmusgrov

This comment has been minimized.

Copy link
Contributor Author

mmusgrov commented Jun 8, 2015

My IDE (intellij) has "Use tab character" unchecked but I will investigate.

@gytis

This comment has been minimized.

Copy link
Member

gytis commented Jun 8, 2015

Fair enough. If it was indented with tabs before, then I think it's correct to use them in the update. However, it doesn't seem consistent in the newly added lines, some are with spaces others are with tabs.

@mmusgrov mmusgrov force-pushed the mmusgrov:JBTM-2308-new-JTS-type-fixes branch from 8a15861 to 5e87398 Jun 8, 2015
@mmusgrov

This comment has been minimized.

Copy link
Contributor Author

mmusgrov commented Jun 8, 2015

The last commit marks the local fields of the two new wrappers private

@jbosstm-bot

This comment has been minimized.

Copy link

jbosstm-bot commented Jun 8, 2015

@jbosstm-bot

This comment has been minimized.

Copy link

jbosstm-bot commented Jun 8, 2015

@jbosstm-bot

This comment has been minimized.

Copy link

jbosstm-bot commented Jun 8, 2015

MAIN profile tests failed (http://172.17.130.4:8083/job/btny-pulls-narayana/PROFILE=MAIN,jdk=jdk8.latest,label=mac/136/): REST-AT To JTA Bridge Test failed

@jbosstm-bot

This comment has been minimized.

@mmusgrov

This comment has been minimized.

Copy link
Contributor Author

mmusgrov commented Jun 8, 2015

MAIN profile tests failure on mac is unrelated. I will look through the mac jobs to see if its a recurrent theme and if so I'll JIRA it.

@gytis gytis assigned mmusgrov and unassigned gytis Jun 9, 2015
@mmusgrov mmusgrov closed this Jun 9, 2015
@mmusgrov mmusgrov deleted the mmusgrov:JBTM-2308-new-JTS-type-fixes branch Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.