Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBTM-2533] Changed 'scripts/hudson/narayana.sh' script to skip '-i' option of used 'sed' commands. #926

Merged
merged 1 commit into from Oct 9, 2015

Conversation

@hhovsepy
Copy link
Contributor

hhovsepy commented Oct 8, 2015

Necessary for running this script on different platforms for QE perspectives.

!BLACKTIE !MAIN !PERF

https://issues.jboss.org/browse/JBTM-2533

…option of used 'sed' commands. Necessary for running this script on different platforms for QE perspectives.
@jbosstm-bot

This comment has been minimized.

Copy link

jbosstm-bot commented Oct 8, 2015

@jbosstm-bot

This comment has been minimized.

Copy link

jbosstm-bot commented Oct 8, 2015

@tomjenkinson

This comment has been minimized.

Copy link
Contributor

tomjenkinson commented Oct 8, 2015

Thanks Hayk, lets see how CI does with it and make sure it didn;t break for the linux nodes.

@jbosstm-bot

This comment has been minimized.

Copy link

jbosstm-bot commented Oct 8, 2015

@jbosstm-bot

This comment has been minimized.

Copy link

jbosstm-bot commented Oct 9, 2015

Benchmark output (please refer to the article https://developer.jboss.org/wiki/PerformanceGatesForAcceptingPerformanceFixesInNarayana for information on our testing procedures.

If you just want to run a single benchmark then please refer to the README.md file in our benchmark repository at https://github.com/jbosstm/performance/tree/master/narayana

JMH benchmark run (with args -i 6 -wi 10 -f 10 -r 60)

Comparison (pull request versus master)
(changes within the % range [-3.000000, 10.000000] are regarded as insignificant):

com.hp.mwtests.ts.arjuna.atomicaction.CheckedActionTest.testThreadActionData: 741084.739086 vrs 748280.073584 (-0.961583%: no change)
com.arjuna.ats.jta.xa.performance.JTAStoreTests.jtaTest: 1096.490283 vrs 1044.059629 (5.021806%: no change)
com.hp.mwtests.ts.arjuna.atomicaction.CheckedActionTest.testCheckedAction: 51440.185539 vrs 51731.954139 (-0.564001%: no change)
com.hp.mwtests.ts.arjuna.performance.Performance1.twoPhase: 468181.866877 vrs 465131.355560 (0.655839%: no change)
com.hp.mwtests.ts.arjuna.performance.Performance1.onePhase: 1805529.423214 vrs 1800491.128733 (0.279829%: no change)

For information on the hardware config used for this PR please consult the CI job artefact hwinfo.txt or the job output

If the purpose of this PR is to improve performance then there has been insufficient improvement to warrant a pass. See the previous text for the threshold (range) for passing optimization related PRs

@jbosstm-bot

This comment has been minimized.

@jbosstm-bot

This comment has been minimized.

@jbosstm-bot

This comment has been minimized.

@jbosstm-bot

This comment has been minimized.

Copy link

jbosstm-bot commented Oct 9, 2015

@jbosstm-bot

This comment has been minimized.

@jbosstm-bot

This comment has been minimized.

tomjenkinson added a commit that referenced this pull request Oct 9, 2015
[JBTM-2533] Changed 'scripts/hudson/narayana.sh' script to skip '-i' option of used 'sed' commands.
@tomjenkinson tomjenkinson merged commit aadd7c7 into jbosstm:master Oct 9, 2015
@tomjenkinson

This comment has been minimized.

Copy link
Contributor

tomjenkinson commented Oct 9, 2015

Thanks Hayk - merging.

@hhovsepy

This comment has been minimized.

Copy link
Contributor Author

hhovsepy commented Oct 9, 2015

Thanks Tom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.