Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBTM-2567 Incorrect replay_completion in AfterCrashServiceImpl01 in c… #947

Merged
merged 1 commit into from Nov 26, 2015

Conversation

@mmusgrov
Copy link
Contributor

commented Nov 24, 2015

PROFILE=QA_JTS_JDKORB QA_PROFILE=-Dprofile=hornetq QA_TESTGROUP=crashrecovery02_2

https://issues.jboss.org/browse/JBTM-2567

This PR applies the same fix I made in a previous PR you reviewed, namely #936. I ported the 3 files from qa/CrashRecovery05Impls (each class is are functionally identical in each TestGroup).

@mmusgrov mmusgrov force-pushed the mmusgrov:JBTM-2567 branch from 717cdae to eff1e34 Nov 25, 2015
@@ -26,7 +26,7 @@
// Tyne and Wear,
// UK.
//
// $Id: AfterCrashServiceImpl01.java,v 1.5 2003/07/17 11:52:48 jcoleman Exp $
// $Id: AfterCrashServiceImpl01.java,v 1.5 2003/07/17 11:52:49 jcoleman Exp $

This comment has been minimized.

Copy link
@tomjenkinson

tomjenkinson Nov 25, 2015

Contributor

Intentional?

This comment has been minimized.

Copy link
@mmusgrov

mmusgrov Nov 25, 2015

Author Contributor

I ran a diff between qa/CrashRecovery02Impls/AfterCrashServiceImpl01.java and qa/CrashRecovery05Impls/AfterCrashServiceImpl01.java and thought I saw no diffs (apart from the package name and imports) so I just copied one over the other. So no it was unintentional - I will recheck the diffs

@mmusgrov mmusgrov force-pushed the mmusgrov:JBTM-2567 branch 9 times, most recently from abcad5c to da1ba36 Nov 25, 2015
@mmusgrov mmusgrov force-pushed the mmusgrov:JBTM-2567 branch from da1ba36 to d6cd42d Nov 25, 2015
@jbosstm-bot

This comment has been minimized.

Copy link

commented Nov 25, 2015

@jbosstm-bot

This comment has been minimized.

Copy link

commented Nov 25, 2015

Started testing this pull request with BLACKTIE profile on Windows: http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-catelyn/993/

@jbosstm-bot

This comment has been minimized.

@jbosstm-bot

This comment has been minimized.

Copy link

commented Nov 25, 2015

@jbosstm-bot

This comment has been minimized.

@jbosstm-bot

This comment has been minimized.

Copy link

commented Nov 25, 2015

BLACKTIE profile tests passed on Windows - Job complete http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-catelyn/993/

@gytis gytis assigned mmusgrov and unassigned gytis Nov 26, 2015
@mmusgrov mmusgrov merged commit d6cd42d into jbosstm:master Nov 26, 2015
@mmusgrov mmusgrov deleted the mmusgrov:JBTM-2567 branch Nov 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.