Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBTM-2550 Updated to try to locate an XAResource locally if the deser… #965

Merged
merged 1 commit into from Dec 22, 2015

Conversation

tomjenkinson
Copy link
Contributor

https://issues.jboss.org/browse/JBTM-2550
!BLACKTIE !XTS !QA_JTA !PERF !QA_JTS_JDKORB

@tomjenkinson tomjenkinson force-pushed the JBTM-2550 branch 3 times, most recently from fb899a6 to 6c135eb Compare December 22, 2015 10:29
@jbosstm-bot
Copy link

@tomjenkinson
Copy link
Contributor Author

@zhfeng, please can you take a look too but assigning to Mike to get quick input so I can try to get a new release out

_theXAResource = (XAResource) o.readObject();
try {
_theXAResource = (XAResource) o.readObject();
} catch (ClassNotFoundException cnfe) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like better to move the below jtaxLogger.logger.trace("...") into the try-catch clause.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - I will update the PR as you suggested

@tomjenkinson tomjenkinson force-pushed the JBTM-2550 branch 2 times, most recently from e30d69f to b9de782 Compare December 22, 2015 14:21
@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@zhfeng
Copy link
Collaborator

zhfeng commented Dec 22, 2015

It looks good to me. Thanks Tom !

jtaxLogger.logger.trace("XAResourceRecord.restore_state - XAResource de-serialized");
}
} catch (ClassNotFoundException cnfe) {
jtaxLogger.i18NLogger.warn_could_not_load_class_will_wait_for_bottom_up(cnfe);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a remark: am I correct in assuming the other exception types thrown by o.readObject are unrecoverable and therefore we must not fallback to using bottom up recover? Do the other exception types indicate either mis-configuration or object store corruption?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fair to target CNFE for now https://docs.oracle.com/javase/7/docs/api/java/io/ObjectInputStream.html#readObject() - its distinct from the other ones and the only enhancement request we have is for the CNFE.

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@tomjenkinson tomjenkinson deleted the JBTM-2550 branch June 1, 2016 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants