New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBTM-2550 Updated to try to locate an XAResource locally if the deser… #965
Conversation
fb899a6
to
6c135eb
Compare
Started testing this pull request with QA_JTS_JDKORB profile: http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-jdk8/PROFILE=QA_JTS_JDKORB,jdk=jdk8.latest,label=linux/1370/ |
@zhfeng, please can you take a look too but assigning to Mike to get quick input so I can try to get a new release out |
_theXAResource = (XAResource) o.readObject(); | ||
try { | ||
_theXAResource = (XAResource) o.readObject(); | ||
} catch (ClassNotFoundException cnfe) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like better to move the below jtaxLogger.logger.trace("...") into the try-catch clause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - I will update the PR as you suggested
e30d69f
to
b9de782
Compare
Started testing this pull request with MAIN profile: http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-jdk8/PROFILE=MAIN,jdk=jdk8.latest,label=linux/1371/ |
Started testing this pull request with MAIN profile: http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-jdk8/PROFILE=MAIN,jdk=jdk8.latest,label=linux/1372/ |
It looks good to me. Thanks Tom ! |
jtaxLogger.logger.trace("XAResourceRecord.restore_state - XAResource de-serialized"); | ||
} | ||
} catch (ClassNotFoundException cnfe) { | ||
jtaxLogger.i18NLogger.warn_could_not_load_class_will_wait_for_bottom_up(cnfe); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a remark: am I correct in assuming the other exception types thrown by o.readObject are unrecoverable and therefore we must not fallback to using bottom up recover? Do the other exception types indicate either mis-configuration or object store corruption?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fair to target CNFE for now https://docs.oracle.com/javase/7/docs/api/java/io/ObjectInputStream.html#readObject() - its distinct from the other ones and the only enhancement request we have is for the CNFE.
MAIN profile tests passed - Job complete http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-jdk8/PROFILE=MAIN,jdk=jdk8.latest,label=linux/1371/ |
MAIN profile tests passed - Job complete http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-jdk8/PROFILE=MAIN,jdk=jdk8.latest,label=linux/1372/ |
…ialization of a JTS resource fails
b9de782
to
82ffb50
Compare
QA_JTS_JDKORB profile tests passed - Job complete http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-jdk8/PROFILE=QA_JTS_JDKORB,jdk=jdk8.latest,label=linux/1370/ |
https://issues.jboss.org/browse/JBTM-2550
!BLACKTIE !XTS !QA_JTA !PERF !QA_JTS_JDKORB