Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up"rm -rf project" in Forge Console doesn't delete project #126
Conversation
|
The JIRA is JBIDE-18527 |
| @@ -391,5 +399,19 @@ private IFile determinePomFile(Resource<?> resource) { | |||
| } | |||
| return result; | |||
| } | |||
|
|
|||
| private void removeOrphanedProjects(IWorkspaceRoot workspaceRoot) { | |||
This comment has been minimized.
This comment has been minimized.
fbricon
Dec 3, 2014
Member
I'm not overly thrilled by that. It's not forge's responsibility to cleanup all projects in eclipse
This comment has been minimized.
This comment has been minimized.
koentsje
Dec 4, 2014
Author
Member
Unfortunately, there is currently no other API in Forge to determine which exact project was deleted. But IMO this solution is better then a user issuing a delete on a project and the project still being there afterwards albeit in a very ugly state. I am also not sure if there are scenarios where this piece of code can be harmful at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
koentsje commentedDec 2, 2014
@maxandersen @fbricon @dgolovin Can any of you review this PR please?