Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upJBIDE-12532 and JBIDE-18955: Upgraded to Forge 2.13.0.Final #129
Conversation
|
@nickboldt @fbricon @maxandersen can you review this? |
gastaldi
changed the title
|
DO NOT merge this until 4.2.1 is released. Just in case. :) |
|
4.2.1 is released, can we merge now? |
|
Yes. |
|
wait that means http://tools.jboss.org/blog/2014-12-15-GA-for-luna.html#updated-forge-2-runtime is wrong cc @alexeykazakov |
|
Why? This is for 4.2.2.Final afaik. |
|
@gastaldi is correct. This PR was merged after 4.2.1.Final release. So it's going to 4.2.2. |
|
I stand corrected, I just can't read. Forget anything I said :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gastaldi commentedDec 15, 2014
It also fixes https://issues.jboss.org/browse/JBIDE-12532