[JBIDE-23029] implemented bot test for Scaling with warning #1609

adietish · 2016-09-13T09:03:30Z

No description provided.

vpakan · 2016-09-13T09:08:02Z

Can one of the admins verify this patch?

adietish · 2016-09-13T09:08:42Z

@vpakan I'm looking for feedback so far, please dont merge it yet

adietish · 2016-09-13T12:11:58Z

@jeffmaury dare to review, too?
Example usage of my Requirement classes are in ScalingTest (which I'll move into a separate PR once this is reviewed)

mmalina · 2016-09-13T12:19:08Z

@adietish fyi, the message from vpakan is automatic (Vlado is actually no longer in our qa team) and it is entered whenever a user not included in the jenkins job's whitelist creates a PR.

mlabuda · 2016-09-14T14:41:19Z

....reddeer/src/org/jboss/tools/openshift/reddeer/requirement/OpenShift3ProjectRequirement.java

+		IProjectRequest request = connection.getResourceFactory().stub(ResourceKind.PROJECT_REQUEST, projectSpec.name());
+		request.setDescription(StringUtils.isEmpty(projectSpec.description())? 
+				projectSpec.name() : projectSpec.description());
+		request.setDescription(StringUtils.isEmpty(projectSpec.displayName())? 


there should be request.setDisplayName(...) instead of setDescription

mlabuda · 2016-09-14T14:45:09Z

...shift.reddeer/src/org/jboss/tools/openshift/reddeer/requirement/OpenShift3ResourceUtils.java

+
+	private static Logger LOGGER = new Logger(OpenShift3ResourceUtils.class);
+
+	public static Connection getConnection(String connectionUrlString) {


Add javadoc, because it is not clear enough without description what form should the URL have. I have to look in other places in code, where its used, that it should look like "https://openshift-dev@10.1.2.2:8443".

mlabuda · 2016-09-14T14:49:01Z

...shift.reddeer/src/org/jboss/tools/openshift/reddeer/requirement/OpenShift3ResourceUtils.java

+	 * @return
+	 */
+	public static boolean hasProject(String name, Connection connection) {
+		return getProject(name, connection) != null;


getProject can throw OpenShiftToolsException. Wouldn't it be better also catch such exception and return false in that case? Because if it fails on getting a project, it like it is not there ;)

I dont see #getProject throwing OpenShiftToolsException. What do I miss?

Not directly, but nested. The request in execute method throws the exception "Unable to execute request to...". But maybe it's really rare case and we dont have to bother with it.

mlabuda · 2016-09-14T14:49:22Z

...openshift.reddeer/src/org/jboss/tools/openshift/reddeer/requirement/OpenShift3Resources.java

@@ -0,0 +1,15 @@
+package org.jboss.tools.openshift.reddeer.requirement;


Please add license info.

mlabuda · 2016-09-15T09:26:09Z

....reddeer/src/org/jboss/tools/openshift/reddeer/requirement/OpenShift3ProjectRequirement.java

+	@Retention(RetentionPolicy.RUNTIME)
+    @Target(ElementType.TYPE)
+    public @interface OpenShift3Project {
+		String connectionURL();


Add javadoc for fields in OpenShift3Project annotation so user now how the values should look like. At least for connection which is in a specific form.

You missed this one.

mlabuda · 2016-09-15T09:26:09Z

....reddeer/src/org/jboss/tools/openshift/reddeer/requirement/OpenShift3ServiceRequirement.java

+
+	@Retention(RetentionPolicy.RUNTIME)
+	@Target(ElementType.TYPE)
+	public @interface OpenShift3Service {


Add javadoc for fields in OpenShift3Service annotation so user now how the values should look like. At least for connection which is in a specific form.

mlabuda · 2016-09-15T09:26:09Z

....reddeer/src/org/jboss/tools/openshift/reddeer/requirement/OpenShift3ServiceRequirement.java

+		ensureServiceExists(serviceSpec.service(), serviceSpec.template(), serviceSpec.project(), connection);
+		new WaitUntil(
+				new ServicePodsExist(serviceSpec.service(), serviceSpec.project(), connection)
+				, TimePeriod.ETERNAL);


It's not a good idea to put ETERNAL waiting. If something goes wrong, all tests would fail on this place and it would crash on timeout instead of continuing with other tests. I would suggest TimePeriod.getCustom() and use a long time out, e.g. 15 minutes should be enough, if not, something is wrong and it fails and its ok.

mlabuda · 2016-09-15T09:26:09Z

....jboss.tools.openshift.reddeer/src/org/jboss/tools/openshift/reddeer/utils/DatastoreOS3.java

-		String password = System.getProperty("openshift.password");
-		if (!(password == null || password.equals("") || password.startsWith("${"))) {
+		String password = System.getProperty(KEY_PASSWORD);
+		if (!(StringUtils.isEmpty(password) || password.startsWith("${"))) {


Please add to tests/org.jboss.tools.openshift.ui.bot.test/pom.xml empty property for openshift.password and then we can remove following from condition
|| password.startsWith("${")
Also please add to tests/org.jboss.tools.openshift.ui.bot.test/pom.xml to systemProperties openshift.authmethod and also empty property, to make it runnable via mvn from cli.

mlabuda · 2016-09-15T09:26:09Z

....jboss.tools.openshift.reddeer/src/org/jboss/tools/openshift/reddeer/utils/DatastoreOS3.java

-		String token = System.getProperty("openshift.token");
-		if (!(token == null || token.equals("") || token.startsWith("${"))) {
+		String token = System.getProperty(KEY_TOKEN);
+		if (!(StringUtils.isEmpty(token) || token.startsWith("${"))) {


Can I ask you to also remove || token.startsWith("${")) ? It's not necessary here because of empty property in pom.xml.

mlabuda · 2016-09-15T09:30:04Z

@adietish I've done review of changes. Please address comments where necessary.

adietish · 2016-09-20T14:17:33Z

....reddeer/src/org/jboss/tools/openshift/reddeer/requirement/OpenShift3ProjectRequirement.java

+
+		String projectName = projectSpec.name();
+		Connection connection = OpenShift3ResourceUtils.getConnection(projectSpec.connectionURL());
+		if (OpenShift3ResourceUtils.hasProject(projectName, connection)) {


can you explain, please?

if (!connectionDoesNotHaveProject) {
createProject();
waitForProject();
}

but it is just cosmetics

rhopp · 2016-09-21T09:15:11Z

test this

adietish

+1, changing as suggested

adietish · 2016-09-21T11:02:21Z

@rhopp "test this"?

jkopriva · 2016-09-21T11:08:22Z

@adietish we use "test this" to trigger verification job

psrna · 2016-09-21T11:21:05Z

We should probably change the trigger message to something more meaningful like testPR.

mlabuda · 2016-09-21T11:33:53Z

...t.reddeer/src/org/jboss/tools/openshift/reddeer/requirement/OpenShiftServiceRequirement.java

+ */
+public class OpenShiftServiceRequirement implements Requirement<RequiredService> {
+
+	private static final TimePeriod TIMEPERIOD_WAIT_FOR_BUILD = TimePeriod.getCustom(30 * 60 * 60); // 30mins


This is not ok. Value is in second, so this results into 30 hours.

mlabuda · 2016-09-22T14:13:16Z

@adietish please address #1609 (review) and #1609 (review) and rebase PR and then I can do final tests of PR etc.

adietish · 2016-09-22T20:26:11Z

@mlabuda addressed your comments and did quite some changes in the code. Before merging, ScalingTest should be removed and PR'd in a a separate PR (it's currently included for testing and design purposes)

adietish

changes requsted in comments are done + further changes in the requirement classes

mlabuda · 2016-09-23T11:54:25Z

...t.reddeer/src/org/jboss/tools/openshift/reddeer/requirement/OpenShiftProjectRequirement.java

+		IProject project = OpenShiftResourceUtils.getProject(name, connection);
+		if (project == null) {
+			LOGGER.debug(NLS.bind("Project {0} doesnt exist yet in {1}, creating it.", name, connection.getHost()));
+			project = createProject(projectSpec, connection);


This is not OK. If default values are used ( = usage of requirement without any values in requirement annotation) and project with specified name does not exists, then it in if on line 95 it would continue to condition and on line 97 it fails (com.openshift.restclient.OpenShiftException: Exception trying to POST https://10.1.2.3:8443/oapi/v1/projectrequests response code: 422 ProjectRequest "" is invalid: metadata.name: Required value: name or generateName is required). This is because projectSpec is with no values and in create project its assumed there is value at least for project name

good catch!
it's using the wrong parameter: it should use the projectName (which is either the one specified in the projectSpec or the default), not the projectSpec which might be missing the project name

mlabuda · 2016-10-03T12:36:51Z

UI is not properly updated if test class with requirements is in suite. If I expand a connection in preceding class and than in current test I try to get a project which has been just created by a requirement, it fails because connection tree item is expanded and project is not listed here. Here is minimal classes to reproduce

Suite:

@RunWith(RedDeerSuite.class)
@SuiteClasses({
FirstTest.class,
SecondTest.class
})
public class OpenShiftRequirementsTestSuite {
}

First test class:

@openperspective(JBossPerspective.class)
@RequiredBasicConnection()
@RequiredProject(name=DatastoreOS3.PROJECT2)
public class FirstTest {
@BeforeClass
public static void expandConnection() {
new OpenShiftExplorerView().getOpenShift3Connection().expand();
}
@test
public void passTest() {}
}

Second test class:

@openperspective(JBossPerspective.class)
@RequiredBasicConnection()
@RequiredProject(name=DatastoreOS3.TEST_PROJECT)
public class SecondTest {
@InjectRequirement
private OpenShiftProjectRequirement requiredProject;
@InjectRequirement
private OpenShiftConnectionRequirement requiredConnection;
@before
public void getSecondProject() {
OpenShiftExplorerView explorer = new OpenShiftExplorerView();
explorer.open();
explorer.getOpenShift3Connection(requiredConnection.getConnection())
.getProject(requiredProject.getProjectName());
}
@test
public void passTest() {}
}

Assert that connection is clean (there are no projects on a connection) and run test suite with following VM arguments:

-Dopenshift.username=openshift-dev -Dopenshift.server=https://10.1.2.2:8443 -Dopenshift.password=devel -Dusage_reporting_enabled=false -Dopenshift.authmethod=basic

it is also reproducible from command line, when running tests via maven, so it definitely need to be fixed

adietish · 2016-10-10T13:51:44Z

@mlabuda this is very weird indeed. If there's only SecondTest in the suite, everything works fine. If FirstTest and SecondTest are in the suite - while FirstTest is executed first - SecondTest fails where the project is being fetched from explorer. The project actually exists in core but the explorer seems not to get notified of it and therefore doesn't display it. Manually refreshing - while you put a brk-point into SecondTest - fixes the thing.

adietish · 2016-10-10T14:39:37Z

@mlabuda I found the reason for it. We're currently not watching projects (projects are missing from the list of watched resources in WatchManager). Watching projects is an enhancement that we have filed to https://issues.jboss.org/browse/JBIDE-23184.
I could fix the issue by waiting for the resource to show up in explorer (the wait condition does a refresh). We will have to remove the workaround once the UI is getting notified of changes to the projects.

adietish · 2016-10-10T15:19:04Z

...t.reddeer/src/org/jboss/tools/openshift/reddeer/requirement/OpenShiftProjectRequirement.java

+			 * 
+			 * @see WatchManager#KINDS
+			 */
+			new WaitUntil(new OpenShiftProjectExists(name, connection));


this wait (that refreshes the explorer/connection waits for the project to show up) fixes the issue. It should be remove once https://issues.jboss.org/browse/JBIDE-23184 is resolved

adietish · 2016-10-10T15:26:54Z

@mlabuda I rebased and added a workaround/fix that's waiting & refreshing until the project gets visible in UI. Please test again and refute/accept the new PR

mlabuda · 2016-10-11T08:58:06Z

...ls.openshift.reddeer/src/org/jboss/tools/openshift/reddeer/condition/core/ProjectExists.java

+		super(ResourceKind.PROJECT, name, null, connection);
+	}
+
+//	@Override


Why is this commented out? If it is meant to be used super class test() method, then please remove it, if it is forgotten commented code, please uncomment it.

mlabuda · 2016-10-11T08:58:06Z

...s.openshift.reddeer/src/org/jboss/tools/openshift/reddeer/condition/core/ResourceExists.java

+ * @author adietish@redhat.com
+ *
+ */
+public class ResourceExists extends AbstractWaitCondition {


Would it be possible to merge NamedResourceExists and ResourceExists into one with more constructors and a bit modified logic to satisfy both (connection.getResource(...), if there is a matcher, match response)?

I dont think that this makes a lot of sense. The little code there is in both and the little code that they can share vs the additionally required checks, switches etc.

mlabuda · 2016-10-11T08:58:06Z

...nshift.reddeer/src/org/jboss/tools/openshift/reddeer/requirement/OpenShiftResourceUtils.java

+			return null;
+		}
+
+		for (IResource resource : connection.getResources(ResourceKind.PROJECT)) {


Replace it by safeGetResource(kind, name, null, connection).

mlabuda · 2016-10-11T08:58:06Z

...reddeer/src/org/jboss/tools/openshift/reddeer/wizard/AbstractOpenShiftApplicationWizard.java

+		this(server, username, null);
+	}
+
+	public AbstractOpenShiftApplicationWizard(String server, String username, String project) {


Did not you forget to do something with the project parameter? It's completely ignored in constructor body and this constructor is not used anywhere.

mlabuda · 2016-10-11T08:58:06Z

....reddeer/src/org/jboss/tools/openshift/reddeer/wizard/v3/NewOpenShift3ApplicationWizard.java

 */
-public class NewOpenShift3ApplicationWizard extends NewOpenShiftApplicationWizard {
+public class NewOpenShift3ApplicationWizard extends AbstractOpenShiftApplicationWizard {

 	public NewOpenShift3ApplicationWizard() {
 		super(DatastoreOS3.SERVER, DatastoreOS3.USERNAME);


probably this is the place where constructor with a project parameter should be used and in open methods could be than used the project value?

mlabuda · 2016-10-11T08:58:06Z

....bot.test/src/org/jboss/tools/openshift/ui/bot/test/application/v3/advanced/ScalingTest.java

+
+		replicationController.select();
+		scaleTo(0);
+		Matcher<String> confirmationDialogMatcher = new ShellButtonsMatcher(Arrays.asList("Yes", "No"));


It's really not necessary to implement such robus matcher and trying to get a shell. Please store shell name in OpenShiftLabel.Shell.STOP_DEPLOYMENT and use here new new DefaultShell(OpenShiftLabel.Shell.STOP_DEPLOYMENT));. Because waiting is default, normal, you don't have to wait for the shell, bcs. shell lookup wait for a period of lenght TimePeriod.NORMAL by default.

As you said, it's superior, because it does not rely on dialog titles which are fragile. IMHO the solution is not perfect, because it relies on button labels but it is more robust because it does wait for "some dialog which has Yes/No" (to confirm scaling to 0) which is relying on the function of the upcoming dialog more than it specific outfit. Waiting for a dialog with a specific title is less robust. I dont see why we therefore should downgrade, this makes no sense to me (if you have an electric car, would you replace it by a gas driven one?).

We have discussed on this topic in QE. We agreed this is not the right way to do stuff. You are not changing shell title. If you want to change shell title, there should be a JIRA to reflect it and not just change. And if there is a JIRA it should be reflected in changes to integration tests. And if precise shell title is not enough, you can still use matcher, which could be a regex matcher matching on keywords. Still far better solution.

Having a shell with Yes/No is less robust because there could pop up some shell which you are not expecting which have Yes/No and it fails there.

mlabuda · 2016-10-11T08:58:06Z

....bot.test/src/org/jboss/tools/openshift/ui/bot/test/application/v3/advanced/ScalingTest.java

+		replicationController.select();
+		scaleTo(0);
+		Matcher<String> confirmationDialogMatcher = new ShellButtonsMatcher(Arrays.asList("Yes", "No"));
+		new WaitUntil(new ShellMatchingMatcherIsAvailable(confirmationDialogMatcher));


Also, please remove ShellButtonsMatcher and ShellMatchingMatcherIsAvailable. There is a constructor for a DefaultShell with matcher.

adietish · 2016-10-12T20:10:26Z

@mlabuda please re-review and free for merge or refute

mlabuda · 2016-10-13T11:56:58Z

Please fix ScalingTest issues. Problem is with UI elements. Even requirements create an application, UI is somehow not aware of it and thus it is failing. Basically, there are several issues, one is no existing service, another not running application.

mlabuda · 2016-10-13T12:32:52Z

I've tried to pin down the issues. All issues are caused by 2 problems:

Child of project tree items are not shown correctly. Therefore there is no service visible even it is created. Could be somehow related to https://issues.jboss.org/browse/JBIDE-23184
Service requirement is waiting only for a replication controller. But it takes some time from moment of existing RC to the point of having right amount of application pod running. And while the test passes from service requirement to the point of scaling, where it really need application pods, it is not in correct state. Please consider using waiting for an application pod(s) in Service requirement, not only RC, so we don't have such issues next time. Or add some waiting.

mlabuda · 2016-10-18T07:50:29Z

Unfortunately still it is not good. I run ScalingTest 5 times and it failed 5 times on the same exception. There were 2 other projects under the OpenShift connection, there was no test-project at the moment when I started the test. Issue is there was no eap service shown under a project (on screenshot, no item under test-project in OpenShift explorer view, nor any deployments in properties view, although in another IDE which I had opened I am seeing it). And it resulted with this exception:
org.jboss.reddeer.common.exception.WaitTimeoutExpiredException: Timeout after: 60 s.: Waiting for resource Deployments matching resource name matcher a string containing "eap-app-1" at org.jboss.reddeer.common.wait.AbstractWait.timeoutExceeded(AbstractWait.java:183) at org.jboss.reddeer.common.wait.AbstractWait.wait(AbstractWait.java:136) at org.jboss.reddeer.common.wait.AbstractWait.<init>(AbstractWait.java:101) at org.jboss.reddeer.common.wait.AbstractWait.<init>(AbstractWait.java:71) at org.jboss.reddeer.common.wait.AbstractWait.<init>(AbstractWait.java:56) at org.jboss.reddeer.common.wait.WaitUntil.<init>(WaitUntil.java:47) at org.jboss.tools.openshift.reddeer.requirement.OpenShiftServiceRequirement.fulfill(OpenShiftServiceRequirement.java:133) at org.jboss.reddeer.junit.internal.requirement.Requirements.fulfill(Requirements.java:105) at org.jboss.reddeer.junit.internal.runner.statement.FulfillRequirementsStatement.evaluate(FulfillRequirementsStatement.java:44) at org.jboss.reddeer.junit.internal.runner.statement.RunIBeforeClassExtensions.evaluate(RunIBeforeClassExtensions.java:72) at org.jboss.reddeer.junit.internal.runner.statement.RunAfters.evaluate(RunAfters.java:68) at org.jboss.reddeer.junit.internal.runner.statement.CleanUpRequirementStatement.evaluate(CleanUpRequirementStatement.java:44) at org.jboss.reddeer.junit.internal.runner.statement.RunIAfterClassExtensions.evaluate(RunIAfterClassExtensions.java:59) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.jboss.reddeer.junit.internal.runner.RequirementsRunner.run(RequirementsRunner.java:156) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:678) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382) at org.jboss.reddeer.eclipse.core.RemotePluginTestRunner.main(RemotePluginTestRunner.java:68) at org.jboss.reddeer.eclipse.core.UITestApplication.runTests(UITestApplication.java:125) at org.eclipse.e4.ui.internal.workbench.swt.E4Testable$1.run(E4Testable.java:73) at java.lang.Thread.run(Thread.java:745)

adietish · 2016-10-18T21:55:24Z

@mlabuda one more set of changes. Please test them.


        [JBIDE-23029] impl'd requirements for connection, project, service

* impl'd requirements for connection, project, service * allow UI assertions to specify connection and project

adietish · 2016-10-20T12:45:55Z

@mlabuda with the latest set of changes I had it green 10/10 times when running ScalingTest solo and starting with non-existing test-project (test requirements create project, service, rc etc.).
Please review

adietish · 2016-10-24T14:08:35Z

@rhopp I'd love if you could give this one a try, it's the required so tha people in openshift can do bot tests efficiently.

rhopp · 2016-10-25T14:33:53Z

I spent quite some time with this PR and I can tell that it runs reliably and I see no obvious thing/problem/error/ with this PR which would prevent it from being merged.

adietish · 2016-10-25T14:45:59Z

@rhopp great news, thanks a lot for the quick response and intensive verification!

adietish force-pushed the adietish:JBIDE-23029 branch from c313ee6 to f87f3b7 Sep 13, 2016

adietish force-pushed the adietish:JBIDE-23029 branch 3 times, most recently from 17fa356 to d2a8fc6 Sep 13, 2016

mlabuda reviewed Sep 14, 2016
View changes

...openshift.reddeer/src/org/jboss/tools/openshift/reddeer/requirement/OpenShift3Resources.java Outdated

@@ -0,0 +1,15 @@

package org.jboss.tools.openshift.reddeer.requirement;

This comment has been minimized.

Sign in to view

Copy link

mlabuda Sep 14, 2016
Member

Please add license info.

adietish force-pushed the adietish:JBIDE-23029 branch from d2a8fc6 to 8a61659 Sep 14, 2016

mlabuda reviewed Sep 15, 2016

View changes

adietish reviewed Sep 20, 2016

View changes

adietish force-pushed the adietish:JBIDE-23029 branch from 8a61659 to 2d1f5df Sep 20, 2016

adietish reviewed Sep 21, 2016

View changes

mlabuda reviewed Sep 21, 2016

View changes

adietish force-pushed the adietish:JBIDE-23029 branch 2 times, most recently from 2e89046 to c850c8b Sep 22, 2016

adietish reviewed Sep 23, 2016

View changes

mlabuda suggested changes Sep 23, 2016

View changes

adietish force-pushed the adietish:JBIDE-23029 branch from c850c8b to c640dd5 Sep 23, 2016

adietish force-pushed the adietish:JBIDE-23029 branch 3 times, most recently from 406f2c6 to b7dd2d8 Sep 23, 2016

adietish force-pushed the adietish:JBIDE-23029 branch 3 times, most recently from e9a8182 to 2b0fda9 Oct 10, 2016

adietish reviewed Oct 10, 2016

View changes

mlabuda suggested changes Oct 11, 2016

View changes

adietish force-pushed the adietish:JBIDE-23029 branch 2 times, most recently from cbdcfb0 to effca30 Oct 12, 2016

adietish force-pushed the adietish:JBIDE-23029 branch from effca30 to d360bdb Oct 13, 2016

adietish force-pushed the adietish:JBIDE-23029 branch from d360bdb to 18e7228 Oct 13, 2016

adietish force-pushed the adietish:JBIDE-23029 branch from 18e7228 to 7829d48 Oct 18, 2016

[JBIDE-23029] impl'd requirements for connection, project, service

46f88c1

* impl'd requirements for connection, project, service * allow UI assertions to specify connection and project

adietish force-pushed the adietish:JBIDE-23029 branch from 7829d48 to 46f88c1 Oct 20, 2016

rhopp merged commit 677cd68 into jbosstools:master Oct 25, 2016

jbosstools/jbosstools-integration-tests

Join GitHub today

[JBIDE-23029] implemented bot test for Scaling with warning #1609

[JBIDE-23029] implemented bot test for Scaling with warning #1609

Conversation

adietish commented Sep 13, 2016 • edited

This comment has been minimized.

vpakan commented Sep 13, 2016

This comment has been minimized.

adietish commented Sep 13, 2016

This comment has been minimized.

adietish commented Sep 13, 2016 • edited

This comment has been minimized.

mmalina commented Sep 13, 2016

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mlabuda commented Sep 15, 2016

This comment has been minimized.

adietish Sep 20, 2016 • edited

This comment has been minimized.

mlabuda Sep 20, 2016 • edited

This comment has been minimized.

rhopp commented Sep 21, 2016

adietish left a comment

This comment has been minimized.

adietish commented Sep 21, 2016

This comment has been minimized.

jkopriva commented Sep 21, 2016

This comment has been minimized.

psrna commented Sep 21, 2016

This comment has been minimized.

This comment has been minimized.

mlabuda commented Sep 22, 2016

This comment has been minimized.

adietish commented Sep 22, 2016 • edited

adietish left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mlabuda commented Oct 3, 2016 • edited

This comment has been minimized.

adietish commented Oct 10, 2016

This comment has been minimized.

adietish commented Oct 10, 2016

This comment has been minimized.

This comment has been minimized.

adietish commented Oct 10, 2016

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mlabuda Oct 11, 2016 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mlabuda Oct 12, 2016 • edited

This comment has been minimized.

This comment has been minimized.

adietish commented Oct 12, 2016

This comment has been minimized.

mlabuda commented Oct 13, 2016 • edited

This comment has been minimized.

mlabuda commented Oct 13, 2016

This comment has been minimized.

mlabuda commented Oct 18, 2016 • edited

This comment has been minimized.

adietish commented Oct 18, 2016

adietish commented Sep 13, 2016 •

edited

adietish commented Sep 13, 2016 •

edited

adietish Sep 20, 2016 •

edited

mlabuda Sep 20, 2016 •

edited

adietish commented Sep 22, 2016 •

edited

mlabuda commented Oct 3, 2016 •

edited

mlabuda Oct 11, 2016 •

edited

mlabuda Oct 12, 2016 •

edited

mlabuda commented Oct 13, 2016 •

edited

mlabuda commented Oct 18, 2016 •

edited