Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBDS-3208 use new path to upstream snapshot site >> master #884

Closed
wants to merge 1 commit into from

Conversation

nickboldt
Copy link
Member

No description provided.

@vpakan
Copy link
Contributor

vpakan commented Mar 13, 2015

test this

@vpakan
Copy link
Contributor

vpakan commented Mar 13, 2015

@nickboldt verification build failed. Since we are not using JBT snapshots I think proper change reflecting renaming of property jbosstools-site-stream to jbosstools_stream is covered by #887 am I right?

Ca I close this issue without pushing to github and push #887 instead?

@vpakan vpakan self-assigned this Mar 13, 2015
@mmalina
Copy link
Member

mmalina commented Mar 13, 2015

Yeah, I would like to know what mars/snapshots/updates is. But it seems using that would kind of defeat the use of the property since it has mars hardcoded?

@nickboldt
Copy link
Member Author

It's hard coded, yes. And changes every year, as it has for the past few years.

This year as part of a many-year-long request to standardize our publishing, staging, and releasing processes for JBDS and JBT, I've been migrating content from updates/nightly/ to http://download.jboss.org/jbosstools/mars/snapshots/updates/

Similarly, builds/staging is now http://download.jboss.org/jbosstools/mars/snapshots/builds/

So, URLs embedded in parent pom and reused by downstream projects also need to change.

@nickboldt
Copy link
Member Author

The reason the verification build failed is that I was waiting on multiple projects upstream of the JBT aggregates to fix their parent POM's so they could be built. You could push #887 but it's an incomplete fix; you will still need to update the full URL later anyway.

So, my advice is just wait on pushing this PR until the upstream is ready.

@vpakan
Copy link
Contributor

vpakan commented Mar 16, 2015

test this

@mmalina
Copy link
Member

mmalina commented Mar 16, 2015

OK, then I guess there is no other option for us but follow the changes. But to me the whole jbosstools_stream property is not all that useful anymore if we need to update the url manually when the time comes anyway.

@nickboldt
Copy link
Member Author

The stream simply defines if you're building & publishing from master, or from the 4.3.0.*x branch.
The overall URL is still adopted from the parent pom, and we DO change it every year, because we build against a new Eclipse platform every year.

@mmalina
Copy link
Member

mmalina commented Mar 16, 2015

The overall URL is hardcoded in our pom.xml, so we have to update it manually. It's not taken from the parent pom.

@nickboldt
Copy link
Member Author

True...

https://github.com/jbosstools/jbosstools-integration-tests/blob/master/pom.xml#L34-L35

could be changed to:

${jbosstools_site_baseurl}/jbosstools-build-sites.aggregate.site_${jbosstools_stream}/${jbosstools_site_suffix}
${jbosstools_site_baseurl}/jbosstools-build-sites.aggregate.coretests-site_${jbosstools_stream}/${jbosstools_site_suffix}

If you want to use the latest nightly build composites (1 or more builds).

Or, you could use these, to link to ONLY the latest single update site:

http://download.jboss.org/jbosstools/mars/snapshots/updates/core/${jbosstools_stream}/
http://download.jboss.org/jbosstools/mars/snapshots/updates/coretests/${jbosstools_stream}/

@vpakan vpakan closed this Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants