Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upJBIDE-18903 Refactor implementations of ITagLibRecognizer #416
Conversation
...g.jboss.tools.jst.web.kb/src/org/jboss/tools/jst/web/kb/internal/JQueryMobileRecognizer.java
Outdated
| } | ||
| return JQueryMobileVersion.JQM_1_4.toString(); | ||
| } | ||
|
|
||
| /** | ||
| * Returns the version of JQM declared in the file or null if there is no JQM declaration. | ||
| * Returns the default version is the declared one is unknown. | ||
| * @param context | ||
| * @return | ||
| */ |
This comment has been minimized.
This comment has been minimized.
plugins/org.jboss.tools.jst.web.kb/src/org/jboss/tools/jst/web/kb/taglib/ITagLibRecognizer.java
Outdated
| @@ -32,7 +32,7 @@ | |||
| * @param context | |||
| * @return | |||
| */ | |||
| boolean isUsed(IHTMLLibraryVersion version, ELContext context); | |||
| boolean isUsed(ELContext context); | |||
|
|
|||
| /** | |||
| * Returns true if the library with the given version is used in this file. | |||
This comment has been minimized.
This comment has been minimized.
alexeykazakov
Dec 9, 2014
Contributor
We should to change the javadoc since we don't pass any version in this method anymore
Second contribution to refactoring. Interface methods changed boolean ITagLibRecognizer.isUsed(ELContext context); boolean ITagLibRecognizer.isUsed(IFile file); IHTMLLibraryVersion ITagLibVersionRecognizer.getVersion(ELContext context); Interface ITagLibVersionRecognizer is implemented by HTMLRecognizer and IonicRecognizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
scabanovich commentedDec 9, 2014
Second contribution to refactoring. Interface methods changed
boolean ITagLibRecognizer.isUsed(ELContext context);
boolean ITagLibRecognizer.isUsed(IFile file);
IHTMLLibraryVersion ITagLibVersionRecognizer.getVersion(ELContext context);
Interface ITagLibVersionRecognizer is implemented by HTMLRecognizer
and IonicRecognizer.