Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBIDE-25813] adapter: name resource that couldn't be found when failing #1696

Merged
merged 1 commit into from Mar 14, 2018

Conversation

@adietish
Copy link
Member

adietish commented Mar 14, 2018

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?
@adietish adietish requested a review from robstryker Mar 14, 2018
Copy link
Member

robstryker left a comment

Looks clean and safe, but you forgot to signoff, so this review will probably disappear once you fix it ;)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish adietish force-pushed the adietish:JBIDE-25813 branch from 8a69161 to 1dc288a Mar 14, 2018
@adietish

This comment has been minimized.

Copy link
Member Author

adietish commented Mar 14, 2018

testPR

@adietish adietish merged commit 3344f30 into jbosstools:master Mar 14, 2018
3 checks passed
3 checks passed
DCO All commits have a DCO sign-off from the author
Red Hat Jenkins Build finished.
Details
sonarqube SonarQube reported no issues
@adietish adietish deleted the adietish:JBIDE-25813 branch Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.